[SyncFS] Remove a friendship between MetadataDatabase and MetadataDatabaseIndex

[SyncFS] Remove a friendship between MetadataDatabase and MetadataDatabaseIndex

BUG=347425
TEST=./unit_tests --gtest_filter="MetadataDatabaseTest.*:MetadataDatabaseIndexTest.*"

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278359

[peria, 2014-06-19 06:00:04]

PTL

[nhiroki, 2014-06-19 06:21:43]

lgtm

[tzik, 2014-06-19 06:23:11]

lgtm

https://codereview.chromium.org/340243004/diff/40001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/drive_backend/metadata_database.cc (right):

https://codereview.chromium.org/340243004/diff/40001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database.cc:1980: const
FileTracker& tracker = *(index_->GetFileTracker(tracker_id));
Could you change this type to FileTracker* and add below just in case?
if (!tracker) {NOTREACHED(); continue;}

https://codereview.chromium.org/340243004/diff/40001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database.cc:2037: const
FileMetadata *file = index_->GetFileMetadata(file_id);
ditto.

[peria, 2014-06-19 06:30:55]

https://codereview.chromium.org/340243004/diff/40001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/drive_backend/metadata_database.cc (right):

https://codereview.chromium.org/340243004/diff/40001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database.cc:1980: const
FileTracker& tracker = *(index_->GetFileTracker(tracker_id));
On 2014/06/19 06:23:11, tzik wrote:
> Could you change this type to FileTracker* and add below just in case?
> if (!tracker) {NOTREACHED(); continue;}

Done.

https://codereview.chromium.org/340243004/diff/40001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database.cc:2037: const
FileMetadata *file = index_->GetFileMetadata(file_id);
On 2014/06/19 06:23:11, tzik wrote:
> ditto.

Done.

[peria, 2014-06-19 06:31:15]

The CQ bit was checked by peria@chromium.org

[commit-bot: I haz the power, 2014-06-19 06:33:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/peria@chromium.org/340243004/60001

[commit-bot: I haz the power, 2014-06-19 13:58:01]

Change committed as 278359