Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 340243002: [NaCl SDK] update_nacl_manifest updates canary to the latest available bundle. (Closed)

Created:
6 years, 6 months ago by binji
Modified:
6 years, 6 months ago
Reviewers:
Sam Clegg
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] update_nacl_manifest updates canary to the latest available bundle. Also switch bionic_canary over to being updated automatically. pepper_canary used to update based on the Chrome canary version, but that often prevents pepper_canary from updating as quickly. It also is unlikely that a newer pepper_canary than Chrome canary will cause any issues. This change makes pepper_canary (and bionic_canary) update based solely on which bundles are available in the cloud storage bucket. BUG=none R=sbc@chromium.org TEST=update_nacl_manifest_test.py Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278396

Patch Set 1 #

Total comments: 4

Patch Set 2 : feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -249 lines) Patch
M native_client_sdk/src/build_tools/json/naclsdk_manifest2.json View 1 chunk +4 lines, -13 lines 0 comments Download
M native_client_sdk/src/build_tools/tests/update_nacl_manifest_test.py View 1 7 chunks +24 lines, -141 lines 0 comments Download
M native_client_sdk/src/build_tools/update_nacl_manifest.py View 1 21 chunks +86 lines, -95 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
binji
6 years, 6 months ago (2014-06-18 23:34:44 UTC) #1
Sam Clegg
lgtm https://codereview.chromium.org/340243002/diff/1/native_client_sdk/src/build_tools/tests/update_nacl_manifest_test.py File native_client_sdk/src/build_tools/tests/update_nacl_manifest_test.py (right): https://codereview.chromium.org/340243002/diff/1/native_client_sdk/src/build_tools/tests/update_nacl_manifest_test.py#newcode231 native_client_sdk/src/build_tools/tests/update_nacl_manifest_test.py:231: result.append(MakeGsUrl(short_filename)) Somehow I feel this block could be ...
6 years, 6 months ago (2014-06-18 23:52:09 UTC) #2
binji
https://codereview.chromium.org/340243002/diff/1/native_client_sdk/src/build_tools/tests/update_nacl_manifest_test.py File native_client_sdk/src/build_tools/tests/update_nacl_manifest_test.py (right): https://codereview.chromium.org/340243002/diff/1/native_client_sdk/src/build_tools/tests/update_nacl_manifest_test.py#newcode231 native_client_sdk/src/build_tools/tests/update_nacl_manifest_test.py:231: result.append(MakeGsUrl(short_filename)) On 2014/06/18 23:52:09, Sam Clegg wrote: > Somehow ...
6 years, 6 months ago (2014-06-19 00:12:14 UTC) #3
Sam Clegg
slgtm
6 years, 6 months ago (2014-06-19 00:27:12 UTC) #4
binji
6 years, 6 months ago (2014-06-19 16:21:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r278396 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698