Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 340233002: GN: Use -Wl,-filelist for rsp files on mac instead of @ (Closed)

Created:
6 years, 6 months ago by jamesr
Modified:
6 years, 6 months ago
Reviewers:
Nico, brettw
CC:
chromium-reviews, brettw, scottmg
Project:
chromium
Visibility:
Public.

Description

GN: Use -Wl,-filelist for rsp files on mac instead of @ The mac GN build exceeds the command line limit when linking large targets like webkit_unit_tests. The fix is to pass a response file to the linker instead of passing a list of object files. Passing this by @rspfile ends up expanding the list before calling clang, so this instead passes it via the filelist parameter. BUG=386046 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278424

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M build/toolchain/mac/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
jamesr
6 years, 6 months ago (2014-06-18 23:27:19 UTC) #1
Nico
"cl descriptions should answer 'why?'"
6 years, 6 months ago (2014-06-18 23:32:12 UTC) #2
Nico
…but other than that, lgtm
6 years, 6 months ago (2014-06-18 23:32:28 UTC) #3
Nico
win already uses in_newline, only linux still uses rspfile_content = $in now. Might want to ...
6 years, 6 months ago (2014-06-18 23:33:53 UTC) #4
jamesr
I'd rather not change things on linux until we see a problem there.
6 years, 6 months ago (2014-06-18 23:39:55 UTC) #5
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 6 months ago (2014-06-18 23:39:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/340233002/1
6 years, 6 months ago (2014-06-18 23:42:40 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-19 08:31:42 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/74731)
6 years, 6 months ago (2014-06-19 08:31:43 UTC) #9
jamesr
Brett, could you OWNERS approve + CQ? Thanks!
6 years, 6 months ago (2014-06-19 17:50:49 UTC) #10
brettw
lgtm Whoopps, sorry.
6 years, 6 months ago (2014-06-19 17:58:13 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 18:16:44 UTC) #12
Message was sent while issue was closed.
Change committed as 278424

Powered by Google App Engine
This is Rietveld 408576698