Issue 34023002: Handlify Map::CopyForObserved

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 34023002: Handlify Map::CopyForObserved (Closed)

Created:
7 years, 2 months ago by rafaelw

Modified:
7 years, 2 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Handlify Map::CopyForObserved R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17327

Patch Set 2 : remove raw declaratin #

Total comments: 2

Patch Set 3 : cr changes #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -24 lines)			Patch
	M	src/objects.h	View	1 2	2 chunks	+6 lines, -1 line	0 comments	Download
	M	src/objects.cc	View	1 2	2 chunks	+25 lines, -23 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM with a nit. https://codereview.chromium.org/34023002/diff/40001/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/34023002/diff/40001/src/objects.cc#newcode6942 src/objects.cc:6942: Map::AddTransition(map, handle(isolate->heap()->observed_symbol()), nit: Better use ...

7 years, 2 months ago (2013-10-22 09:28:22 UTC) #2

rafaelw

https://codereview.chromium.org/34023002/diff/40001/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/34023002/diff/40001/src/objects.cc#newcode6942 src/objects.cc:6942: Map::AddTransition(map, handle(isolate->heap()->observed_symbol()), On 2013/10/22 09:28:22, Michael Starzinger wrote: > ...

7 years, 2 months ago (2013-10-22 17:24:08 UTC) #3