Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 340223002: Add ArrayDataTraits<> specialization for Array_Data<T>*. (Closed)

Created:
6 years, 6 months ago by yzshen1
Modified:
6 years, 6 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Add ArrayDataTraits<> specialization for Array_Data<T>*. Currently, we use wrong storage type for nested arrays. For example, the storage type of the outer array of int8[][] is StructPointer<Array_Data<int8_t>>. After this CL it will be ArrayPointer<int8_t>. The current code works because StructPointer happens to be of the same size as ArrayPointer. (The newly-added tests pass with/without this CL. But I think it is good to have them.) BUG=None TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278356

Patch Set 1 #

Patch Set 2 : #

Messages

Total messages: 5 (0 generated)
yzshen1
Hi, Darin. Would you please take a look? Thanks!
6 years, 6 months ago (2014-06-18 22:48:02 UTC) #1
darin (slow to review)
LGTM Good catch!
6 years, 6 months ago (2014-06-19 05:44:01 UTC) #2
yzshen1
The CQ bit was checked by yzshen@chromium.org
6 years, 6 months ago (2014-06-19 05:51:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/340223002/20001
6 years, 6 months ago (2014-06-19 05:54:05 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 13:34:21 UTC) #5
Message was sent while issue was closed.
Change committed as 278356

Powered by Google App Engine
This is Rietveld 408576698