Issue 340213002: Move addStylesheetByURL from WebFrame to WebLocalFrame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 340213002: Move addStylesheetByURL from WebFrame to WebLocalFrame. (Closed)

Created:
6 years, 6 months ago by dcheng

Modified:
6 years, 6 months ago

Reviewers:
shatch, abarth-chromium

CC:
abarth-chromium, blink-reviews, dglazkov+blink, jamesr

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

Move addStylesheetByURL from WebFrame to WebLocalFrame. There's no reason this would ever be called on remote frames. BUG=386340 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176486

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -22 lines)			Patch
M	Source/web/WebLocalFrameImpl.h	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	Source/web/WebLocalFrameImpl.cpp	View	2 chunks	+11 lines, -11 lines	0 comments	Download
M	Source/web/WebRemoteFrameImpl.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/web/WebRemoteFrameImpl.cpp	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	public/web/WebFrame.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	public/web/WebLocalFrame.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/340213002/1

6 years, 6 months ago (2014-06-19 03:28:19 UTC) #4

Message was sent while issue was closed.

Change committed as 176486