Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: runtime/vm/flow_graph.cc

Issue 340203003: Cleanup of error and warning reporting. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/exceptions_test.cc ('k') | runtime/vm/flow_graph_builder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph.cc
===================================================================
--- runtime/vm/flow_graph.cc (revision 37467)
+++ runtime/vm/flow_graph.cc (working copy)
@@ -7,8 +7,8 @@
#include "vm/bit_vector.h"
#include "vm/flow_graph_builder.h"
#include "vm/intermediate_language.h"
-#include "vm/longjump.h"
#include "vm/growable_array.h"
+#include "vm/report.h"
namespace dart {
@@ -1147,16 +1147,13 @@
void FlowGraph::Bailout(const char* reason) const {
const Function& function = parsed_function_.function();
- const Error& error = Error::Handle(
- LanguageError::NewFormatted(Error::Handle(), // No previous error.
- Script::Handle(function.script()),
- function.token_pos(),
- LanguageError::kError,
- Heap::kNew,
- "FlowGraph Bailout: %s %s",
- String::Handle(function.name()).ToCString(),
- reason));
- Isolate::Current()->long_jump_base()->Jump(1, error);
+ Report::MessageF(Report::kBailout,
+ Script::Handle(function.script()),
+ function.token_pos(),
+ "FlowGraph Bailout: %s %s",
+ String::Handle(function.name()).ToCString(),
+ reason);
+ UNREACHABLE();
}
« no previous file with comments | « runtime/vm/exceptions_test.cc ('k') | runtime/vm/flow_graph_builder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698