Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Side by Side Diff: runtime/vm/compiler.cc

Issue 340203003: Cleanup of error and warning reporting. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/compiler.h" 5 #include "vm/compiler.h"
6 6
7 #include "vm/assembler.h" 7 #include "vm/assembler.h"
8 8
9 #include "vm/ast_printer.h" 9 #include "vm/ast_printer.h"
10 #include "vm/block_scheduler.h" 10 #include "vm/block_scheduler.h"
(...skipping 602 matching lines...) Expand 10 before | Expand all | Expand 10 after
613 OS::Print("%s\n", error.ToErrorCString()); 613 OS::Print("%s\n", error.ToErrorCString());
614 } 614 }
615 done = true; 615 done = true;
616 ASSERT(optimized || 616 ASSERT(optimized ||
617 (FLAG_warn_on_javascript_compatibility && 617 (FLAG_warn_on_javascript_compatibility &&
618 FLAG_warning_as_error)); 618 FLAG_warning_as_error));
619 } 619 }
620 620
621 // Clear the error if it was not a real error, but just a bailout. 621 // Clear the error if it was not a real error, but just a bailout.
622 if (error.IsLanguageError() && 622 if (error.IsLanguageError() &&
623 (LanguageError::Cast(error).kind() == LanguageError::kBailout)) { 623 (LanguageError::Cast(error).kind() == Report::kBailout)) {
624 isolate->object_store()->clear_sticky_error(); 624 isolate->object_store()->clear_sticky_error();
625 } 625 }
626 is_compiled = false; 626 is_compiled = false;
627 } 627 }
628 // Reset global isolate state. 628 // Reset global isolate state.
629 isolate->set_deopt_id(prev_deopt_id); 629 isolate->set_deopt_id(prev_deopt_id);
630 } 630 }
631 return is_compiled; 631 return is_compiled;
632 } 632 }
633 633
(...skipping 346 matching lines...) Expand 10 before | Expand all | Expand 10 after
980 const Object& result = 980 const Object& result =
981 Object::Handle(isolate->object_store()->sticky_error()); 981 Object::Handle(isolate->object_store()->sticky_error());
982 isolate->object_store()->clear_sticky_error(); 982 isolate->object_store()->clear_sticky_error();
983 return result.raw(); 983 return result.raw();
984 } 984 }
985 UNREACHABLE(); 985 UNREACHABLE();
986 return Object::null(); 986 return Object::null();
987 } 987 }
988 988
989 } // namespace dart 989 } // namespace dart
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698