Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: plugins/org.chromium.sdk/src/org/chromium/sdk/internal/JavascriptVmImpl.java

Issue 3402011: Support 'break on exception' feature (Closed)
Patch Set: follow codereview Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: plugins/org.chromium.sdk/src/org/chromium/sdk/internal/JavascriptVmImpl.java
diff --git a/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/JavascriptVmImpl.java b/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/JavascriptVmImpl.java
index 31772466ea84d3f56a090a52a7c600c5cb2c588f..45c655d4866d0da252a911665178534518caa083 100644
--- a/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/JavascriptVmImpl.java
+++ b/plugins/org.chromium.sdk/src/org/chromium/sdk/internal/JavascriptVmImpl.java
@@ -10,6 +10,8 @@ import org.chromium.sdk.Breakpoint;
import org.chromium.sdk.CallbackSemaphore;
import org.chromium.sdk.JavascriptVm;
import org.chromium.sdk.SyncCallback;
+import org.chromium.sdk.JavascriptVm.ExceptionCatchType;
+import org.chromium.sdk.JavascriptVm.SetValueCallback;
import org.chromium.sdk.internal.tools.v8.MethodIsBlockingException;
/**
@@ -46,10 +48,17 @@ public abstract class JavascriptVmImpl implements JavascriptVm {
getDebugSession().getBreakpointManager().reloadBreakpoints(callback, syncCallback);
}
- public void enableBreakpoints(boolean enabled, Void callback, SyncCallback syncCallback) {
+ public void enableBreakpoints(Boolean enabled, SetValueCallback<Boolean> callback,
+ SyncCallback syncCallback) {
getDebugSession().getBreakpointManager().enableBreakpoints(enabled, callback, syncCallback);
}
+ public void setBreakOnException(ExceptionCatchType catchType, Boolean enabled,
+ SetValueCallback<Boolean> callback, SyncCallback syncCallback) {
+ getDebugSession().getBreakpointManager().setBreakOnException(catchType, enabled,
+ callback, syncCallback);
+ }
+
protected abstract DebugSession getDebugSession();
// TODO(peter.rybin): This message will be obsolete in JavaSE-1.6.

Powered by Google App Engine
This is Rietveld 408576698