Google codestyle prescribes sorting #include filenames within a section....

Google codestyle prescribes sorting #include filenames within a section.
Do it fast with following shell script:

export LC_ALL=C
find chrome/browser/chromeos/ -name '*.h' -o -name '*.cc' \
  | xargs grep -C1 '^#include' \
  | awk -F: '$2 !~ "include" { prev=""; next } ($2 <= prev) { print $1 } { prev=$2 }' \
  | uniq \
  | xargs -n1 sh -c 'cat "$1" \
                       | awk "{ tag=((/^#include/) \"_\" (/</) \"_\" (/third.party/)); print tag \"\t\" \$0 }" \
                       | awk -vi=0 -F\\t "{ if (!/^1_0_/ || \$1 != prev) { ++i } } { printf \"%09d\t%s\n\",i,\$0; prev=\$1 }" \
                       | sort \
                       | sed "s/^[0-9]*\t[0-9]_[0-9]_[0-9]\t//" > "$1".fixed; mv -f "$1".fixed "$1"' xxx

BUG=None
TEST=Manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=59646

[Denis Lagno, 2010-09-16 13:37:08]

please take a look

[Dmitry Polukhin, 2010-09-16 13:51:44]

LGTM

Thanks a lot for doing this!

It would be good to add this check in resubmit scripts to make sure that headers
will be sort in future.

[Denis Lagno, 2010-09-16 15:48:12]

On 2010/09/16 13:51:44, Dmitry Polukhin wrote:
> It would be good to add this check in resubmit scripts to make sure that
headers
> will be sort in future.

It looks like cpplint.py has this check implemented
but depot_tools/presubmit_canned_checks.py explicitly disables include_order
check for some justified reason:

  # Justifications for each filter:
  # - build/include_order : Not happening; #ifdefed includes.

[Nikita (slow), 2010-09-16 15:50:52]

Great!

I'd say we should submit this scripttoo so that other parts of repository could
be cleaned up as well.
As the other thing (which is better) - run it for all Chromium repository (may
be split into parts) and enable presubmit check.