Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 340153004: Move gn secondary_source to the build/ directory (Closed)

Created:
6 years, 6 months ago by Chris Masone
Modified:
6 years, 6 months ago
Reviewers:
brettw, Torne
CC:
chromium-reviews, tfarina, jshin+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Move gn secondary_source to the build/ directory It's a goodness to sequester build configuration in the build/ directory. The gn secondary_source stuff was under tools/gn for historical reasons, so move it to a more appropriate place. BUG=None TEST=do a gn build of base_unittests, run said unittests. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278355

Patch Set 1 #

Patch Set 2 : Add change to angle build file #

Patch Set 3 : move licenses check exception from tools/gn to build/secondary #

Patch Set 4 : Update android webview_licenses.py as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-16 lines, -4627 lines) Patch
M .gn View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/tools/webview_licenses.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + build/secondary/chrome/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/secondary/testing/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/secondary/testing/gmock/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/secondary/testing/gtest/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/secondary/third_party/WebKit/Source/platform/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/secondary/third_party/WebKit/Source/wtf/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/secondary/third_party/android_tools/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/secondary/third_party/angle/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
A + build/secondary/third_party/angle/angle_commit.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/secondary/third_party/flac/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/secondary/third_party/freetype/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/secondary/third_party/icu/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/secondary/third_party/leveldatabase/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/secondary/third_party/libjpeg_turbo/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/secondary/third_party/nss/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/secondary/third_party/ots/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/secondary/third_party/sfntly/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/secondary/third_party/speex/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/secondary/third_party/trace-viewer/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/secondary/tools/grit/grit_rule.gni View 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/secondary/ui/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
D tools/gn/secondary/chrome/BUILD.gn View 1 chunk +0 lines, -299 lines 0 comments Download
D tools/gn/secondary/testing/BUILD.gn View 1 chunk +0 lines, -11 lines 0 comments Download
D tools/gn/secondary/testing/gmock/BUILD.gn View 1 chunk +0 lines, -45 lines 0 comments Download
D tools/gn/secondary/testing/gtest/BUILD.gn View 1 chunk +0 lines, -104 lines 0 comments Download
D tools/gn/secondary/third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +0 lines, -73 lines 0 comments Download
D tools/gn/secondary/third_party/WebKit/Source/wtf/BUILD.gn View 1 chunk +0 lines, -364 lines 0 comments Download
D tools/gn/secondary/third_party/android_tools/BUILD.gn View 1 chunk +0 lines, -17 lines 0 comments Download
D tools/gn/secondary/third_party/angle/BUILD.gn View 1 chunk +0 lines, -644 lines 0 comments Download
D tools/gn/secondary/third_party/angle/angle_commit.h View 1 chunk +0 lines, -8 lines 0 comments Download
D tools/gn/secondary/third_party/flac/BUILD.gn View 1 chunk +0 lines, -76 lines 0 comments Download
D tools/gn/secondary/third_party/freetype/BUILD.gn View 1 chunk +0 lines, -52 lines 0 comments Download
D tools/gn/secondary/third_party/icu/BUILD.gn View 1 chunk +0 lines, -444 lines 0 comments Download
D tools/gn/secondary/third_party/leveldatabase/BUILD.gn View 1 chunk +0 lines, -338 lines 0 comments Download
D tools/gn/secondary/third_party/libjpeg_turbo/BUILD.gn View 1 chunk +0 lines, -216 lines 0 comments Download
D tools/gn/secondary/third_party/nss/BUILD.gn View 1 chunk +0 lines, -1159 lines 0 comments Download
D tools/gn/secondary/third_party/ots/BUILD.gn View 1 chunk +0 lines, -90 lines 0 comments Download
D tools/gn/secondary/third_party/sfntly/BUILD.gn View 1 chunk +0 lines, -129 lines 0 comments Download
D tools/gn/secondary/third_party/speex/BUILD.gn View 1 chunk +0 lines, -90 lines 0 comments Download
D tools/gn/secondary/third_party/trace-viewer/BUILD.gn View 1 chunk +0 lines, -320 lines 0 comments Download
D tools/gn/secondary/tools/grit/grit_rule.gni View 1 chunk +0 lines, -153 lines 0 comments Download
D tools/gn/secondary/ui/BUILD.gn View 1 chunk +0 lines, -11 lines 0 comments Download
M tools/licenses.py View 1 2 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Chris Masone
I did the following to test: $ gn gen out/Debug $ ninja -C out/Debug base_unittests ...
6 years, 6 months ago (2014-06-18 19:16:49 UTC) #1
brettw
lgtm
6 years, 6 months ago (2014-06-18 19:18:46 UTC) #2
Chris Masone
Hm, tryserver failures with problems like: ninja -C /mnt/scratch0/b_used/build/slave/linux_chromium_gn/build/src/out/Release all -j50 ninja: Entering directory `/mnt/scratch0/b_used/build/slave/linux_chromium_gn/build/src/out/Release' ...
6 years, 6 months ago (2014-06-18 19:22:52 UTC) #3
brettw
In build/secondary/third_party/angle/BUILD.gn, update this line: hardcoded_commit = [ "//tools/gn/secondary/third_party/angle/angle_commit.h" ] I think that is probably ...
6 years, 6 months ago (2014-06-18 19:25:11 UTC) #4
Chris Masone
+torne for android_webview license.py change
6 years, 6 months ago (2014-06-18 21:27:50 UTC) #5
Chris Masone
On 2014/06/18 21:27:50, Chris Masone wrote: > +torne for android_webview license.py change please note that ...
6 years, 6 months ago (2014-06-18 22:28:06 UTC) #6
Torne
android_webview LGTM
6 years, 6 months ago (2014-06-19 09:59:14 UTC) #7
Chris Masone
The CQ bit was checked by cmasone@chromium.org
6 years, 6 months ago (2014-06-19 12:52:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmasone@chromium.org/340153004/60001
6 years, 6 months ago (2014-06-19 12:53:25 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 13:14:32 UTC) #10
Message was sent while issue was closed.
Change committed as 278355

Powered by Google App Engine
This is Rietveld 408576698