Issue 340153002: Add hooks to get the GN binaries in buildtools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 340153002: Add hooks to get the GN binaries in buildtools. (Closed)

Created:
6 years, 6 months ago by brettw

Modified:
6 years, 6 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add hooks to get the GN binaries in buildtools. This keeps the old hooks for the binaries in the old location. I'm going to keep both for abo0ut a week, then update depot tools to point to the new ones (otherwise people who run depot tools without syncing the repo past this point can't run GN from the command line). BUG= R=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278145

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -3 lines)			Patch
	M	DEPS	View		3 chunks	+49 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

brettw

6 years, 6 months ago (2014-06-18 19:23:23 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r278145 (presubmit successful).

Expand Messages | Collapse Messages