Disabled form control elements should not be active

Disabled form control elements should not be active

Clicking on a disabled form control element like a button should not
make it active. This patch adds a check for the disabled element before
setting the activation. This is as per the spec 
http://www.whatwg.org/specs/web-apps/current-work/multipage/selectors.html#selector-active
This matches the behavior on IE. Firefox behavior is same as Chrome.

BUG=385601
TEST=fast/css/disabled-form-control-elements-should-not-be-active.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176501

[spartha, 2014-06-18 15:15:30]

PTAL

[tkent, 2014-06-18 23:53:37]

lgtm

https://codereview.chromium.org/340143002/diff/20001/LayoutTests/fast/css/dis...
File
LayoutTests/fast/css/disabled-form-control-elements-should-not-be-active.html
(right):

https://codereview.chromium.org/340143002/diff/20001/LayoutTests/fast/css/dis...
LayoutTests/fast/css/disabled-form-control-elements-should-not-be-active.html:16:
<pre id="description"></pre>
This element is unnecessary.  js-test.js generates it.

https://codereview.chromium.org/340143002/diff/20001/LayoutTests/fast/css/dis...
LayoutTests/fast/css/disabled-form-control-elements-should-not-be-active.html:17:
<pre id="console"></pre>
Ditto.

https://codereview.chromium.org/340143002/diff/20001/LayoutTests/fast/css/dis...
LayoutTests/fast/css/disabled-form-control-elements-should-not-be-active.html:21:
function shouldHaveBackground(element, bg) {
Do not indent the top-level code.

<script>
function shouldHave....

https://codereview.chromium.org/340143002/diff/20001/LayoutTests/fast/css/dis...
LayoutTests/fast/css/disabled-form-control-elements-should-not-be-active.html:26:
description("Style :active should not be applied for disabled Form Control
elements");
Inconsistent quotes.  Other code use single-quotes, this line uses
double-quotes.

[spartha, 2014-06-19 07:56:34]

The CQ bit was checked by sudarshan.p@samsung.com

[spartha, 2014-06-19 07:57:19]

Thanks!

https://codereview.chromium.org/340143002/diff/20001/LayoutTests/fast/css/dis...
File
LayoutTests/fast/css/disabled-form-control-elements-should-not-be-active.html
(right):

https://codereview.chromium.org/340143002/diff/20001/LayoutTests/fast/css/dis...
LayoutTests/fast/css/disabled-form-control-elements-should-not-be-active.html:16:
<pre id="description"></pre>
On 2014/06/18 23:53:36, tkent wrote:
> This element is unnecessary.  js-test.js generates it.

Done.

https://codereview.chromium.org/340143002/diff/20001/LayoutTests/fast/css/dis...
LayoutTests/fast/css/disabled-form-control-elements-should-not-be-active.html:17:
<pre id="console"></pre>
On 2014/06/18 23:53:37, tkent wrote:
> Ditto.

Done.

https://codereview.chromium.org/340143002/diff/20001/LayoutTests/fast/css/dis...
LayoutTests/fast/css/disabled-form-control-elements-should-not-be-active.html:21:
function shouldHaveBackground(element, bg) {
On 2014/06/18 23:53:37, tkent wrote:
> Do not indent the top-level code.
> 
> <script>
> function shouldHave....

Done.

https://codereview.chromium.org/340143002/diff/20001/LayoutTests/fast/css/dis...
LayoutTests/fast/css/disabled-form-control-elements-should-not-be-active.html:26:
description("Style :active should not be applied for disabled Form Control
elements");
On 2014/06/18 23:53:37, tkent wrote:
> Inconsistent quotes.  Other code use single-quotes, this line uses
> double-quotes.

Done.

[commit-bot: I haz the power, 2014-06-19 07:57:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sudarshan.p@samsung.com/340143002/60001

[commit-bot: I haz the power, 2014-06-19 09:51:05]

Change committed as 176501