Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 340103002: fix last skp bug (Closed)

Created:
6 years, 6 months ago by caryclark
Modified:
6 years, 6 months ago
Reviewers:
reed
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Fix last pathops skp bug This fixes the last bug discovered by iterating through the 800K skp corpus representing the top 1M websites. For every clip on the stack, the paths are replaced with the pathop intersection. The resulting draw is compared with the original draw for pixel errors. At least two prominent bugs remain. In one, the winding value is confused by a cubic with an inflection. In the other, a quad/cubic pair, nearly coincident, fails to find an intersection. These minor changes include ignoring very tiny self-intersections of cubics, and processing degenerate edges that don't connect to anything else. TBR=reed Committed: https://skia.googlesource.com/skia/+/e4097e3a0b10bb0047a45b6949ca01826f0807a7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+274 lines, -724 lines) Patch
M src/pathops/SkDCubicIntersection.cpp View 1 chunk +9 lines, -3 lines 0 comments Download
M src/pathops/SkOpSegment.h View 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkOpSegment.cpp View 4 chunks +51 lines, -8 lines 0 comments Download
M src/pathops/SkPathOpsDebug.cpp View 1 chunk +6 lines, -1 line 0 comments Download
M tests/PathOpsCubicQuadIntersectionTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsDebug.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M tests/PathOpsOpTest.cpp View 14 chunks +27 lines, -27 lines 0 comments Download
M tests/PathOpsSkpTest.cpp View 4 chunks +0 lines, -6 lines 0 comments Download
M tests/PathOpsTestCommon.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/PathOpsTestCommon.cpp View 1 chunk +88 lines, -0 lines 0 comments Download
M tools/pathops_sorter.htm View 1 chunk +6 lines, -0 lines 0 comments Download
M tools/pathops_visualizer.htm View 2 chunks +81 lines, -676 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
caryclark
The CQ bit was checked by caryclark@google.com
6 years, 6 months ago (2014-06-18 14:13:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/caryclark@google.com/340103002/1
6 years, 6 months ago (2014-06-18 14:14:16 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 14:24:25 UTC) #3
Message was sent while issue was closed.
Change committed as e4097e3a0b10bb0047a45b6949ca01826f0807a7

Powered by Google App Engine
This is Rietveld 408576698