Issue 340093003: Added an assertion verifying that a Canvas2DLayerBridge is not deleted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 340093003: Added an assertion verifying that a Canvas2DLayerBridge is not deleted (Closed)

Created:
6 years, 6 months ago by Rémi Piotaix

Modified:
6 years, 6 months ago

Reviewers:
Justin Novosad

CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Added an assertion verifying that a Canvas2DLayerBridge is not deleted when still in the Canvas2DLayerManager list. In order to be able to call Canvas2DLayerManager::isInList, the method has been changed from private to public. BUG=385141 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176442

Patch Set 1 #

Patch Set 2 : Formatting error corrected #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	Source/platform/graphics/Canvas2DLayerBridge.cpp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
	M	Source/platform/graphics/Canvas2DLayerManager.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Justin Novosad

On 2014/06/18 14:38:27, Rémi Piotaix wrote: > PTAL lgtm as long as the tests pass. ...

6 years, 6 months ago (2014-06-18 15:37:09 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piotaixr@chromium.org/340093003/20001

6 years, 6 months ago (2014-06-18 17:21:47 UTC) #4

Message was sent while issue was closed.

Change committed as 176442

Expand Messages | Collapse Messages