Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 340073002: Extend WebFallbackFont by fciId (Closed)

Created:
6 years, 6 months ago by Dominik Röttsches
Modified:
6 years, 6 months ago
CC:
abarth-chromium, blink-reviews, dglazkov+blink, jamesr
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Extend WebFallbackFont by fciId Required for instantiating the fallback fonts from the sandbox since this instantiation is not allowed by filename, but only through Skia's SkFontConfigInterface, where paths are previously kept track of in the Linux sandbox support process. Preparation for a Chromium side change which fills fciId. BUG=285303 R=abarth,eae Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176494

Patch Set 1 #

Total comments: 1

Patch Set 2 : Name spelled out. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M public/platform/linux/WebFallbackFont.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Dominik Röttsches
PTAL
6 years, 6 months ago (2014-06-18 13:25:01 UTC) #1
abarth-chromium
https://codereview.chromium.org/340073002/diff/1/public/platform/linux/WebFallbackFont.h File public/platform/linux/WebFallbackFont.h (right): https://codereview.chromium.org/340073002/diff/1/public/platform/linux/WebFallbackFont.h#newcode42 public/platform/linux/WebFallbackFont.h:42: int fciId; // Corresponds to Skia Fontconfig Interface (FCI) ...
6 years, 6 months ago (2014-06-18 23:37:33 UTC) #2
Dominik Röttsches
Name spelled out.
6 years, 6 months ago (2014-06-19 05:34:34 UTC) #3
eseidel
rslgtm
6 years, 6 months ago (2014-06-19 05:53:37 UTC) #4
Dominik Röttsches
The CQ bit was checked by dominik.rottsches@intel.com
6 years, 6 months ago (2014-06-19 06:10:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominik.rottsches@intel.com/340073002/20001
6 years, 6 months ago (2014-06-19 06:11:07 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 07:17:35 UTC) #7
Message was sent while issue was closed.
Change committed as 176494

Powered by Google App Engine
This is Rietveld 408576698