Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/native_handler.dart

Issue 340023003: Various caches for incremental compilation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Only allocate caches when hasIncrementalCompilation is true. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/sdk/lib/_internal/compiler/implementation/native_handler.dart
diff --git a/dart/sdk/lib/_internal/compiler/implementation/native_handler.dart b/dart/sdk/lib/_internal/compiler/implementation/native_handler.dart
index f53d34846da48259480446a986da66d29ce0e4ef..ae675562cbe82b7194dbc1c5b3481ace4b5f8a34 100644
--- a/dart/sdk/lib/_internal/compiler/implementation/native_handler.dart
+++ b/dart/sdk/lib/_internal/compiler/implementation/native_handler.dart
@@ -90,6 +90,8 @@ abstract class NativeEnqueuerBase implements NativeEnqueuer {
final Set<ClassElement> pendingClasses = new Set<ClassElement>();
final Set<ClassElement> unusedClasses = new Set<ClassElement>();
+ final Set<LibraryElement> processedLibraries;
+
bool hasInstantiatedNativeClasses() => !registeredClasses.isEmpty;
final Set<ClassElement> nativeClassesAndSubclasses = new Set<ClassElement>();
@@ -121,9 +123,17 @@ abstract class NativeEnqueuerBase implements NativeEnqueuer {
ClassElement _annotationJsNameClass;
/// Subclasses of [NativeEnqueuerBase] are constructed by the backend.
- NativeEnqueuerBase(this.world, this.compiler, this.enableLiveTypeAnalysis);
+ NativeEnqueuerBase(this.world, Compiler compiler, this.enableLiveTypeAnalysis)
+ : this.compiler = compiler,
+ processedLibraries = compiler.cacheStrategy.newSet();
void processNativeClasses(Iterable<LibraryElement> libraries) {
+ if (compiler.hasIncrementalSupport) {
+ // Since [Set.add] returns bool if an element was added, this restricts
+ // [libraries] to ones that haven't already been processed. This saves
+ // time during incremental compiles.
+ libraries = libraries.where(processedLibraries.add);
+ }
libraries.forEach(processNativeClassesInLibrary);
if (compiler.isolateHelperLibrary != null) {
processNativeClassesInLibrary(compiler.isolateHelperLibrary);

Powered by Google App Engine
This is Rietveld 408576698