Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 3400008: Add mosys into host-depends for signing images (Closed)

Created:
10 years, 3 months ago by Hung-Te
Modified:
9 years, 7 months ago
Reviewers:
Nick Sanders
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, tedbo, adlr, anush
Visibility:
Public.

Description

Add mosys into host-depends for signing images BUG=none TEST=manual Change-Id: I1e97cf06a867acd3fe42f74f2c34a1e52834a282

Patch Set 1 #

Patch Set 2 : add r65 symlink #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, --1 lines) Patch
M chromeos-base/hard-host-depends/hard-host-depends-0.0.1.ebuild View 1 chunk +1 line, -0 lines 0 comments Download
A + chromeos-base/hard-host-depends/hard-host-depends-0.0.1-r65.ebuild View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Hung-Te
10 years, 3 months ago (2010-09-16 02:39:31 UTC) #1
Nick Sanders
lgtm
10 years, 3 months ago (2010-09-16 02:41:46 UTC) #2
Nick Sanders
hard to tell from the cl, did you "git mv hard-host-depends-0.0.1-r63.ebuild hard-host-depends-0.0.1-r64.ebuild"?
10 years, 3 months ago (2010-09-16 02:42:44 UTC) #3
Hung-Te
No, I used git rm then manually add r65 (oops, forgot to add that) (just ...
10 years, 3 months ago (2010-09-16 03:01:02 UTC) #4
Nick Sanders
10 years, 3 months ago (2010-09-16 03:06:14 UTC) #5
No, yours is fine, i haven't added the revision bump

On Wed, Sep 15, 2010 at 8:01 PM, <hungte@chromium.org> wrote:

> No, I used git rm then manually add r65 (oops, forgot to add that)
>
> (just saw your http://codereview.chromium.org/3446005/show ... should I
> drop
> this one?)
>
>
> http://codereview.chromium.org/3400008/show
>

Powered by Google App Engine
This is Rietveld 408576698