Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 339963002: Remove SVG paint order runtime flag (Closed)

Created:
6 years, 6 months ago by rwlbuis
Modified:
6 years, 6 months ago
Reviewers:
pdr., esprehn
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove SVG paint order runtime flag Remove SVG paint order runtime flag, since this has been stable for a while. This also removes one check in CSSPropertyParser. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176372

Patch Set 1 #

Patch Set 2 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M LayoutTests/svg/css/script-tests/svg-paint-order.js View 1 2 chunks +0 lines, -5 lines 0 comments Download
M Source/core/css/RuntimeCSSEnabled.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
rwlbuis
PTAL, as discussed in #ksvg.
6 years, 6 months ago (2014-06-17 22:44:21 UTC) #1
esprehn
On 2014/06/17 at 22:44:21, rob.buis wrote: > PTAL, as discussed in #ksvg. Has this actually ...
6 years, 6 months ago (2014-06-17 23:04:29 UTC) #2
esprehn
On 2014/06/17 at 23:04:29, esprehn wrote: > On 2014/06/17 at 22:44:21, rob.buis wrote: > > ...
6 years, 6 months ago (2014-06-17 23:06:42 UTC) #3
pdr.
On 2014/06/17 23:06:42, esprehn wrote: > On 2014/06/17 at 23:04:29, esprehn wrote: > > On ...
6 years, 6 months ago (2014-06-17 23:19:51 UTC) #4
esprehn
lgtm
6 years, 6 months ago (2014-06-17 23:27:03 UTC) #5
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 6 months ago (2014-06-17 23:55:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/339963002/20001
6 years, 6 months ago (2014-06-17 23:55:31 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 01:23:56 UTC) #8
Message was sent while issue was closed.
Change committed as 176372

Powered by Google App Engine
This is Rietveld 408576698