Issue 339953002: Move usbDevices permission out to //extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 339953002: Move usbDevices permission out to //extensions. (Closed)

Created:
6 years, 6 months ago by Ken Rockot(use gerrit already)

Modified:
6 years, 6 months ago

Reviewers:
Yoyo Zhou

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Move usbDevices permission out to //extensions. Let the base ExtensionAPIPermissions set provide the usbDevices permission, rather than restricting it to Chrome only. BUG=385738 R=yoz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277927

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	chrome/common/extensions/permissions/chrome_api_permissions.cc	View		2 chunks	+0 lines, -3 lines	0 comments	Download
	M	extensions/common/permissions/extensions_api_permissions.cc	View		2 chunks	+3 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

Ken Rockot(use gerrit already)

Could you take a quick look? Trivial change so we can use usbDevices in app_shell.

6 years, 6 months ago (2014-06-17 19:39:55 UTC) #1

Ken Rockot(use gerrit already)

The CQ bit was checked by rockot@chromium.org

6 years, 6 months ago (2014-06-17 20:28:04 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/339953002/1

6 years, 6 months ago (2014-06-17 20:30:50 UTC) #4

Message was sent while issue was closed.

Change committed as 277927