Issue 339943002: Small fixes in mojo_shell for android.

Issue 339943002: Small fixes in mojo_shell for android. (Closed)

Created:
6 years, 6 months ago by qsr

Modified:
6 years, 6 months ago

Reviewers:
viettrungluu

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Small fixes in mojo_shell for android. R=viettrungluu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278149

Patch Set 4 : Fix typo #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -6 lines)			Patch
M	mojo/mojo.gyp	View		2 chunks	+8 lines, -1 line	0 comments	Download
M	mojo/shell/mojo_url_resolver.cc	View		2 chunks	+7 lines, -2 lines	0 comments	Download
M	mojo/shell/shell_test_base.cc	View	1 2 3	2 chunks	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

LGTM w/nit. (Other comment is mostly for me. Possibly, we should unify shell_test_base.cc's path stuff ...

6 years, 6 months ago (2014-06-17 23:02:06 UTC) #2

qsr

https://codereview.chromium.org/339943002/diff/20001/mojo/shell/shell_test_base.cc File mojo/shell/shell_test_base.cc (right): https://codereview.chromium.org/339943002/diff/20001/mojo/shell/shell_test_base.cc#newcode11 mojo/shell/shell_test_base.cc:11: #include "build/build_config.h" On 2014/06/17 23:02:06, viettrungluu wrote: > nit: ...

6 years, 6 months ago (2014-06-18 00:00:04 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/339943002/40001

6 years, 6 months ago (2014-06-18 00:00:49 UTC) #5

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 6 months ago (2014-06-18 06:13:07 UTC) #6

commit-bot: I haz the power

Try jobs failed on following builders: linux_chromium_chromeos_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_clang_dbg/builds/23991)

6 years, 6 months ago (2014-06-18 06:13:08 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/339943002/60001

6 years, 6 months ago (2014-06-18 15:33:57 UTC) #9

Message was sent while issue was closed.

Change committed as 278149

Expand Messages | Collapse Messages