Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: src/IceTargetLoweringX8632.cpp

Issue 339933004: Change some tests to be valid PNaCl IR (parameter type from i1 -> i32). (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests_lit/llvm2ice_tests/bool-opt.ll » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceTargetLoweringX8632.cpp
diff --git a/src/IceTargetLoweringX8632.cpp b/src/IceTargetLoweringX8632.cpp
index 1e510471a902343e8b794a3dd7a8a9a1eb20862a..dbfe60f334a7aa3a11308d600cc45aa924e0269c 100644
--- a/src/IceTargetLoweringX8632.cpp
+++ b/src/IceTargetLoweringX8632.cpp
@@ -1281,6 +1281,8 @@ void TargetX8632::lowerCall(const InstCall *Instr) {
_mov(T, Arg);
_push(T);
} else {
+ // Otherwise PNaCl requires parameter types to be at least 32-bits.
+ assert(Arg->getType() == IceType_f32 || Arg->getType() == IceType_i32);
_push(Arg);
}
StackOffset += typeWidthInBytesOnStack(Arg->getType());
« no previous file with comments | « no previous file | tests_lit/llvm2ice_tests/bool-opt.ll » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698