Issue 339933004: Change some tests to be valid PNaCl IR (parameter type from i1 -> i32).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 339933004: Change some tests to be valid PNaCl IR (parameter type from i1 -> i32). (Closed)

Created:
6 years, 6 months ago by jvoung (off chromium)

Modified:
6 years, 6 months ago

Reviewers:
Jim Stichnoth, Derek Schuff

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Visibility:
Public.

More Reviews

Description

Change some tests to be valid PNaCl IR (parameter type from i1 -> i32). Change the i1 zeroext parameter to an explicit zext and i32. Add an assert in lowerCall that the type is at least 32-bits. I ended up putting the assert in lowerCall instead of InstX8632Push, since technically there are quite a few modes that push allows: 16-bit reg/mem (just not 8-bit reg/mem) and 8/16/32 bit constants. BUG=none R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=bdbe402

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -5 lines)			Patch
M	src/IceTargetLoweringX8632.cpp	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests_lit/llvm2ice_tests/bool-opt.ll	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	tests_lit/llvm2ice_tests/cmp-opt.ll	View	1 chunk	+5 lines, -3 lines	0 comments	Download
M	tests_lit/llvm2ice_tests/fp.pnacl.ll	View	1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jvoung (off chromium)

6 years, 6 months ago (2014-06-18 00:12:33 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as rbdbe402 (presubmit successful).

Expand Messages | Collapse Messages