Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 339933002: [NaCl SDK] Add BIONIC to NACLSDK (Closed)

Created:
6 years, 6 months ago by noelallen1
Modified:
6 years, 6 months ago
Reviewers:
binji
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Project:
chromium
Visibility:
Public.

Description

Add BIONIC to NACLSDK Adds BIONIC to the manifest. This is a precursor to automated updates for bionic. This change only affects the SDK updater and the automated JSON generator, and is not visible to chrome. R=binji@chromium.org BUG=344574 NOTRY=true TEST=naclsdk update -U Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277832

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M native_client_sdk/src/build_tools/json/naclsdk_manifest2.json View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
noelallen1
ptal
6 years, 6 months ago (2014-06-17 17:15:57 UTC) #1
binji
lgtm
6 years, 6 months ago (2014-06-17 17:19:04 UTC) #2
noelallen1
6 years, 6 months ago (2014-06-17 19:13:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r277832 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698