Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 339923004: * Removed bitmapshaders from expectations/gm/ignored-tests.txt. (Closed)

Created:
6 years, 6 months ago by dandov
Modified:
6 years, 6 months ago
Reviewers:
jvanverth1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

* Removed bitmapshaders from expectations/gm/ignored-tests.txt. * Rebaseline bitmapshaders, gpu didn't produce the same images when using only alpha bitmaps because it didn't consider the skpaint's color. BUG=skia:2293 Committed: https://skia.googlesource.com/skia/+/baa860c297ec315690e4837b5354cd4fd1fc9fc0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+297 lines, -126 lines) Patch
M expectations/gm/Test-Android-Logan-Nvidia-Arm7-Debug/expected-results.json View 1 chunk +15 lines, -6 lines 0 comments Download
M expectations/gm/Test-Android-Logan-Nvidia-Arm7-Release/expected-results.json View 1 chunk +15 lines, -6 lines 0 comments Download
M expectations/gm/Test-Android-Nexus10-MaliT604-Arm7-Debug/expected-results.json View 1 chunk +10 lines, -4 lines 0 comments Download
M expectations/gm/Test-Android-Nexus10-MaliT604-Arm7-Release/expected-results.json View 1 chunk +10 lines, -4 lines 0 comments Download
M expectations/gm/Test-Android-Nexus4-Adreno320-Arm7-Debug/expected-results.json View 1 chunk +4 lines, -1 line 0 comments Download
M expectations/gm/Test-Android-Nexus4-Adreno320-Arm7-Release/expected-results.json View 1 chunk +4 lines, -1 line 0 comments Download
M expectations/gm/Test-Android-Nexus7-Tegra3-Arm7-Debug/expected-results.json View 1 chunk +4 lines, -1 line 0 comments Download
M expectations/gm/Test-Android-Nexus7-Tegra3-Arm7-Release/expected-results.json View 1 chunk +4 lines, -1 line 0 comments Download
M expectations/gm/Test-Android-Xoom-Tegra2-Arm7-Debug/expected-results.json View 1 chunk +4 lines, -1 line 0 comments Download
M expectations/gm/Test-Android-Xoom-Tegra2-Arm7-Release/expected-results.json View 1 chunk +4 lines, -1 line 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Debug/expected-results.json View 1 chunk +5 lines, -2 lines 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Release/expected-results.json View 1 chunk +5 lines, -2 lines 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 1 chunk +5 lines, -2 lines 0 comments Download
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json View 1 chunk +5 lines, -2 lines 0 comments Download
M expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86-Debug/expected-results.json View 1 chunk +5 lines, -2 lines 0 comments Download
M expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86-Release/expected-results.json View 1 chunk +5 lines, -2 lines 0 comments Download
M expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 1 chunk +5 lines, -2 lines 0 comments Download
M expectations/gm/Test-Mac10.7-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json View 1 chunk +5 lines, -2 lines 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86-Debug/expected-results.json View 1 chunk +5 lines, -2 lines 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86-Release/expected-results.json View 1 chunk +5 lines, -2 lines 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Debug/expected-results.json View 1 chunk +5 lines, -2 lines 0 comments Download
M expectations/gm/Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Release/expected-results.json View 1 chunk +5 lines, -2 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86-Debug/expected-results.json View 1 chunk +9 lines, -9 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/expected-results.json View 1 chunk +9 lines, -9 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86_64-Debug/expected-results.json View 1 chunk +9 lines, -9 lines 0 comments Download
M expectations/gm/Test-Ubuntu12-ShuttleA-GTX660-x86_64-Release/expected-results.json View 1 chunk +9 lines, -9 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug-ANGLE/expected-results.json View 1 chunk +5 lines, -2 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug-DirectWrite/expected-results.json View 1 chunk +13 lines, -4 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Debug/expected-results.json View 1 chunk +13 lines, -4 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release-ANGLE/expected-results.json View 1 chunk +5 lines, -2 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release-DirectWrite/expected-results.json View 1 chunk +13 lines, -4 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86-Release/expected-results.json View 1 chunk +4 lines, -1 line 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86_64-Debug/expected-results.json View 1 chunk +5 lines, -2 lines 0 comments Download
M expectations/gm/Test-Win7-ShuttleA-HD2000-x86_64-Release/expected-results.json View 1 chunk +5 lines, -2 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-GTX660-x86-Debug/expected-results.json View 1 chunk +12 lines, -3 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-GTX660-x86-Release/expected-results.json View 1 chunk +12 lines, -3 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-GTX660-x86_64-Debug/expected-results.json View 1 chunk +12 lines, -3 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-GTX660-x86_64-Release/expected-results.json View 1 chunk +12 lines, -3 lines 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-HD7770-x86-Debug/expected-results.json View 1 chunk +4 lines, -1 line 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-HD7770-x86-Release/expected-results.json View 1 chunk +4 lines, -1 line 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-HD7770-x86_64-Debug/expected-results.json View 1 chunk +4 lines, -1 line 0 comments Download
M expectations/gm/Test-Win8-ShuttleA-HD7770-x86_64-Release/expected-results.json View 1 chunk +4 lines, -1 line 0 comments Download
M expectations/gm/ignored-tests.txt View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jvanverth1
lgtm
6 years, 6 months ago (2014-06-17 17:54:14 UTC) #1
dandov
The CQ bit was checked by dandov@google.com
6 years, 6 months ago (2014-06-17 17:54:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/dandov@google.com/339923004/1
6 years, 6 months ago (2014-06-17 17:55:04 UTC) #3
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 18:21:53 UTC) #4
Message was sent while issue was closed. 
Change committed as baa860c297ec315690e4837b5354cd4fd1fc9fc0

Powered by Google App Engine
This is Rietveld 408576698