Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 339903005: Use HTMLMediaElement's helpers for the video fullscreen button (Closed)

Created:
6 years, 5 months ago by philipj_slow
Modified:
6 years, 5 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, nessy, vcarbune.chromium
Project:
blink
Visibility:
Public.

Description

Use HTMLMediaElement's helpers for the controls fullscreen button This isolates ExemptIFrameAllowFullScreenRequirement to a single call site and makes the code more readable. R=acolwell@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177045

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M Source/core/html/shadow/MediaControlElements.cpp View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
philipj_slow
6 years, 5 months ago (2014-06-26 09:26:13 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm
6 years, 5 months ago (2014-06-26 15:38:02 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 5 months ago (2014-06-26 15:42:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/339903005/1
6 years, 5 months ago (2014-06-26 15:44:24 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-06-26 19:17:22 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-06-26 19:27:24 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/13864)
6 years, 5 months ago (2014-06-26 19:27:24 UTC) #7
philipj_slow
6 years, 5 months ago (2014-06-27 02:27:54 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r177045 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698