Make sure ThreadSanitizer v2 reports a data race in ToolsSanityTest.DataRace.

Make sure ThreadSanitizer v2 reports a data race in ToolsSanityTest.DataRace.

BUG=351259
R=phajdan@chromium.org
TBR=thakis@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279994

[Alexander Potapenko, 2014-06-17 09:36:50]

Please take a look (see also the letter I've sent you regarding EXPECT_EXIT vs.
test launcher).

[Paweł Hajdan Jr., 2014-06-25 04:19:41]

LGTM

[Alexander Potapenko, 2014-06-25 08:52:52]

The CQ bit was checked by glider@chromium.org

[commit-bot: I haz the power, 2014-06-25 08:54:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/glider@chromium.org/339893002/1

[Alexander Potapenko, 2014-06-25 12:14:10]

TBRing Nico for base ownership.

[commit-bot: I haz the power, 2014-06-25 13:50:59]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[Nico, 2014-06-25 16:10:22]

https://codereview.chromium.org/339893002/diff/1/base/tools_sanity_unittest.cc
File base/tools_sanity_unittest.cc (right):

https://codereview.chromium.org/339893002/diff/1/base/tools_sanity_unittest.c...
base/tools_sanity_unittest.cc:310: // TODO(glider): remove this path when TSan
v1 is retired.
Isn't this done?

[Alexander Potapenko, 2014-06-25 16:18:06]

On 2014/06/25 16:10:22, Nico (away) wrote:
> https://codereview.chromium.org/339893002/diff/1/base/tools_sanity_unittest.cc
> File base/tools_sanity_unittest.cc (right):
> 
>
https://codereview.chromium.org/339893002/diff/1/base/tools_sanity_unittest.c...
> base/tools_sanity_unittest.cc:310: // TODO(glider): remove this path when TSan
> v1 is retired.
> Isn't this done?

Good catch! Fixed.

[Alexander Potapenko, 2014-06-25 19:54:56]

The CQ bit was checked by glider@chromium.org

[commit-bot: I haz the power, 2014-06-25 19:55:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/glider@chromium.org/339893002/20001

[commit-bot: I haz the power, 2014-06-25 20:40:00]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/20...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-25 20:42:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-25 20:42:32]

Try jobs failed on following builders:
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)

[Alexander Potapenko, 2014-06-26 08:49:27]

The CQ bit was checked by glider@chromium.org

[commit-bot: I haz the power, 2014-06-26 08:50:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/glider@chromium.org/339893002/20001

[Alexander Potapenko, 2014-06-26 09:07:16]

The CQ bit was checked by glider@chromium.org

[commit-bot: I haz the power, 2014-06-26 09:08:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/glider@chromium.org/339893002/40001

[commit-bot: I haz the power, 2014-06-26 13:10:54]

Change committed as 279994