src/x64/regexp-macro-assembler-x64.cc - Issue 339883002: Interrupts must not mask stack overflow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/regexp-macro-assembler-x64.cc

Issue 339883002: Interrupts must not mask stack overflow. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/regexp-macro-assembler-x64.cc

diff --git a/src/x64/regexp-macro-assembler-x64.cc b/src/x64/regexp-macro-assembler-x64.cc

index b24d842805c767532261328f0e8f154159c0129e..a8c1cb47a7fa832db16807080c6ff2301d673dda 100644

--- a/src/x64/regexp-macro-assembler-x64.cc

+++ b/src/x64/regexp-macro-assembler-x64.cc

@@ -1183,7 +1183,8 @@ int RegExpMacroAssemblerX64::CheckStackGuardState(Address* return_address,

Code* re_code,

Address re_frame) {

Isolate* isolate = frame_entry<Isolate*>(re_frame, kIsolate);

- if (isolate->stack_guard()->IsStackOverflow()) {

+ StackLimitCheck check(isolate);

+ if (check.JsHasOverflowed()) {

isolate->StackOverflow();

return EXCEPTION;

}

« no previous file with comments | « src/x64/full-codegen-x64.cc ('k') | test/mjsunit/regress/regress-crbug-385002.js » ('j') | no next file with comments »