Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1071)

Unified Diff: src/isolate.h

Issue 339883002: Interrupts must not mask stack overflow. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ia32/regexp-macro-assembler-ia32.cc ('k') | src/isolate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/isolate.h
diff --git a/src/isolate.h b/src/isolate.h
index 439f2ce1948740051cf86e9c9f29b0d82c538414..7de73034cdecb7ad52610fbbcd4d47a054d56fa5 100644
--- a/src/isolate.h
+++ b/src/isolate.h
@@ -1390,15 +1390,20 @@ class ExecutionAccess BASE_EMBEDDED {
};
-// Support for checking for stack-overflows in C++ code.
+// Support for checking for stack-overflows.
class StackLimitCheck BASE_EMBEDDED {
public:
explicit StackLimitCheck(Isolate* isolate) : isolate_(isolate) { }
- bool HasOverflowed() const {
+ // Use this to check for stack-overflows in C++ code.
+ inline bool HasOverflowed() const {
StackGuard* stack_guard = isolate_->stack_guard();
- return (reinterpret_cast<uintptr_t>(this) < stack_guard->real_climit());
+ return reinterpret_cast<uintptr_t>(this) < stack_guard->real_climit();
}
+
+ // Use this to check for stack-overflow when entering runtime from JS code.
+ bool JsHasOverflowed() const;
+
private:
Isolate* isolate_;
};
« no previous file with comments | « src/ia32/regexp-macro-assembler-ia32.cc ('k') | src/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698