Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1323)

Issue 339873003: Add NULL renderer check when setting layer for a remote frame (Closed)

Created:
6 years, 6 months ago by kenrb
Modified:
6 years, 6 months ago
Reviewers:
ojan
CC:
blink-reviews, site-isolation-reviews_chromium.org
Project:
blink
Visibility:
Public.

Description

Add NULL renderer check when setting layer for a remote frame Follow-up to r176130. Ojan noted that the Frame might not have an ownerRenderer, this patch adds a check for that scenario. R=ojan@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176341

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Source/web/WebLocalFrameImpl.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
kenrb
Ojan: This addresses your post-commit comment on the other CL. PTAL?
6 years, 6 months ago (2014-06-17 16:41:59 UTC) #1
ojan
lgtm
6 years, 6 months ago (2014-06-17 16:46:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kenrb@chromium.org/339873003/1
6 years, 6 months ago (2014-06-17 16:46:48 UTC) #3
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 17:50:26 UTC) #4
Message was sent while issue was closed.
Change committed as 176341

Powered by Google App Engine
This is Rietveld 408576698