Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Side by Side Diff: Source/devtools/front_end/timeline/TimelineView.js

Issue 339873002: Fix typo in TimelineView highlighter (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * Copyright (C) 2012 Intel Inc. All rights reserved. 3 * Copyright (C) 2012 Intel Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 808 matching lines...) Expand 10 before | Expand all | Expand 10 after
819 819
820 /** 820 /**
821 * @param {?Element} rowElement 821 * @param {?Element} rowElement
822 * @return {boolean} 822 * @return {boolean}
823 */ 823 */
824 _highlightQuad: function(rowElement) 824 _highlightQuad: function(rowElement)
825 { 825 {
826 if (!rowElement || !rowElement.row) 826 if (!rowElement || !rowElement.row)
827 return false; 827 return false;
828 var presentationRecord = rowElement.row._record; 828 var presentationRecord = rowElement.row._record;
829 if (presentationRecord.collapsed()) 829 if (presentationRecord.coalesced())
830 return false; 830 return false;
831 var record = presentationRecord.record(); 831 var record = presentationRecord.record();
832 if (this._highlightedQuadRecord === record) 832 if (this._highlightedQuadRecord === record)
833 return true; 833 return true;
834 this._highlightedQuadRecord = record; 834 this._highlightedQuadRecord = record;
835 835
836 var quad = record.highlightQuad(); 836 var quad = record.highlightQuad();
837 if (!quad) 837 if (!quad)
838 return false; 838 return false;
839 record.target().domAgent().highlightQuad(quad, WebInspector.Color.PageHi ghlight.Content.toProtocolRGBA(), WebInspector.Color.PageHighlight.ContentOutlin e.toProtocolRGBA()); 839 record.target().domAgent().highlightQuad(quad, WebInspector.Color.PageHi ghlight.Content.toProtocolRGBA(), WebInspector.Color.PageHighlight.ContentOutlin e.toProtocolRGBA());
(...skipping 454 matching lines...) Expand 10 before | Expand all | Expand 10 after
1294 this._element.classList.remove("hidden"); 1294 this._element.classList.remove("hidden");
1295 } else 1295 } else
1296 this._element.classList.add("hidden"); 1296 this._element.classList.add("hidden");
1297 }, 1297 },
1298 1298
1299 _dispose: function() 1299 _dispose: function()
1300 { 1300 {
1301 this._element.remove(); 1301 this._element.remove();
1302 } 1302 }
1303 } 1303 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698