Issue 339863002: rendering_helper: Release GL context before terminate a display.

Issue 339863002: rendering_helper: Release GL context before terminate a display. (Closed)

Created:
6 years, 6 months ago by Owen Lin

Modified:
6 years, 6 months ago

Reviewers:
yuli, Pawel Osciak, scherkus (not reviewing)

CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

rendering_helper: Release GL context before terminate a display. Otherwise, we won't be able to initialize it again. BUG=chrome-os-partner:29674 TEST=Run the unittest on nyan. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277995

Patch Set 1 #

Total comments: 2

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	content/common/gpu/media/rendering_helper.cc	View		2 chunks	+4 lines, -1 line	2 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/owenlin@chromium.org/339863002/1

6 years, 6 months ago (2014-06-18 02:22:30 UTC) #4

Pawel Osciak

https://chromiumcodereview.appspot.com/339863002/diff/1/content/common/gpu/media/rendering_helper.cc File content/common/gpu/media/rendering_helper.cc (right): https://chromiumcodereview.appspot.com/339863002/diff/1/content/common/gpu/media/rendering_helper.cc#newcode401 content/common/gpu/media/rendering_helper.cc:401: CHECK(eglMakeCurrent( Don't we need to glxMakeCurrent for GLX above ...

6 years, 6 months ago (2014-06-19 03:59:23 UTC) #6

Owen Lin

6 years, 6 months ago (2014-06-19 05:21:33 UTC) #7

Message was sent while issue was closed.

https://chromiumcodereview.appspot.com/339863002/diff/1/content/common/gpu/me...
File content/common/gpu/media/rendering_helper.cc (right):

https://chromiumcodereview.appspot.com/339863002/diff/1/content/common/gpu/me...
content/common/gpu/media/rendering_helper.cc:401: CHECK(eglMakeCurrent(
On 2014/06/19 03:59:23, Pawel Osciak wrote:
> Don't we need to glxMakeCurrent for GLX above as well?

No, it only needed for EGL. 
https://chromiumcodereview.appspot.com/271593010/diff/210001/content/common/g...

Expand Messages | Collapse Messages