build/android/pylib/symbols/elf_symbolizer_unittest.py - Issue 339853004: binary_size_tool: fix for ambiguous addr2line output

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/symbols/elf_symbolizer_unittest.py

Issue 339853004: binary_size_tool: fix for ambiguous addr2line output (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: rewrote check for ambiguous paths (now works if current working directory is not the source directo… Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/pylib/symbols/elf_symbolizer_unittest.py

diff --git a/build/android/pylib/symbols/elf_symbolizer_unittest.py b/build/android/pylib/symbols/elf_symbolizer_unittest.py

index 978e621faebfb7b258457ea9ca12f2312eeb827f..5fe4352181574402c99eb9d678ec3724d1da0c23 100755

--- a/build/android/pylib/symbols/elf_symbolizer_unittest.py

+++ b/build/android/pylib/symbols/elf_symbolizer_unittest.py

@@ -155,6 +155,8 @@ class ELFSymbolizerTest(unittest.TestCase):

self.assertIsNone(sym_info.name)

else:

self.assertTrue(sym_info.name.startswith(exp_name))

+ if not exp_source_path is None:

+ exp_source_path = os.path.abspath(exp_source_path)

self.assertEqual(sym_info.source_path, exp_source_path)

self.assertEqual(sym_info.source_line, exp_source_line)

@@ -170,4 +172,4 @@ class ELFSymbolizerTest(unittest.TestCase):

if __name__ == '__main__':

- unittest.main()

+ unittest.main()