build/android/pylib/symbols/elf_symbolizer_unittest.py - Issue 339853004: binary_size_tool: fix for ambiguous addr2line output

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/android/pylib/symbols/elf_symbolizer_unittest.py

Issue 339853004: binary_size_tool: fix for ambiguous addr2line output (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: updated descriptions, rebased, s/os.path.isabs/posixpath.isabs/ Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 #!/usr/bin/env python	1 #!/usr/bin/env python

2 # Copyright 2014 The Chromium Authors. All rights reserved.	2 # Copyright 2014 The Chromium Authors. All rights reserved.

3 # Use of this source code is governed by a BSD-style license that can be	3 # Use of this source code is governed by a BSD-style license that can be

4 # found in the LICENSE file.	4 # found in the LICENSE file.

5	5

6 import functools	6 import functools

7 import logging	7 import logging

8 import os	8 import os

9 import sys	9 import sys

10 import unittest	10 import unittest

(...skipping 152 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
163 self.assertEqual(sym_info.inlined_by.name, exp_name + '_middle')	163 self.assertEqual(sym_info.inlined_by.name, exp_name + '_middle')

164 self.assertEqual(sym_info.inlined_by.inlined_by.name,	164 self.assertEqual(sym_info.inlined_by.inlined_by.name,

165 exp_name + '_outer')	165 exp_name + '_outer')

166	166

167 # Check against duplicate callbacks.	167 # Check against duplicate callbacks.

168 self.assertNotIn(addr, self._resolved_addresses)	168 self.assertNotIn(addr, self._resolved_addresses)

169 self._resolved_addresses.add(addr)	169 self._resolved_addresses.add(addr)

170	170

171	171

172 if __name__ == '__main__':	172 if __name__ == '__main__':

173 unittest.main()	173 unittest.main()

OLD	NEW