Issue 339853003: DevTools: Remove unused isAncestor parameter from findTreeElement in TreeOutline.

Issue 339853003: DevTools: Remove unused isAncestor parameter from findTreeElement in TreeOutline. (Closed)

Created:
6 years, 6 months ago by vsevik

Modified:
6 years, 6 months ago

Reviewers:
lushnikov, yurys

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: Remove unused isAncestor parameter from findTreeElement in TreeOutline. R=lushnikov Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176308

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -16 lines)			Patch
M	Source/devtools/front_end/elements/ElementsTreeOutline.js	View	1 chunk	+2 lines, -7 lines	0 comments	Download
M	Source/devtools/front_end/resources/ResourcesPanel.js	View	1 chunk	+1 line, -7 lines	0 comments	Download
M	Source/devtools/front_end/ui/treeoutline.js	View	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/339853003/1

6 years, 6 months ago (2014-06-17 09:40:16 UTC) #4

yurys

This change broke a couple of console tests: file:///sources/chromium/src/webkit/Release/layout-test-results/results.html

6 years, 6 months ago (2014-06-17 13:51:47 UTC) #6

vsevik

6 years, 6 months ago (2014-06-17 15:49:08 UTC) #7

Message was sent while issue was closed.

On 2014/06/17 13:51:47, yurys wrote:
> This change broke a couple of console tests:
> file:///sources/chromium/src/webkit/Release/layout-test-results/results.html

I think it was a v8 roll, not my patch.

Expand Messages | Collapse Messages