Source/core/rendering/RenderFullScreen.h - Issue 33983003: Introduce DEFINE_RENDER_OBJECT_TYPE_CASTS to replace manual toRenderFoo, and use it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderFullScreen.h

Issue 33983003: Introduce DEFINE_RENDER_OBJECT_TYPE_CASTS to replace manual toRenderFoo, and use it (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderFullScreen.h

diff --git a/Source/core/rendering/RenderFullScreen.h b/Source/core/rendering/RenderFullScreen.h

index 65665d36d40e9bda2ef02ed99e2a1be01a68e456..48c40f4f7fe5db58a4aa74189145c2dcf08486a6 100644

--- a/Source/core/rendering/RenderFullScreen.h

+++ b/Source/core/rendering/RenderFullScreen.h

@@ -54,14 +54,8 @@ protected:

RenderBlock* m_placeholder;

};

-inline RenderFullScreen* toRenderFullScreen(RenderObject* object)

- ASSERT_WITH_SECURITY_IMPLICATION(object->isRenderFullScreen());

- return static_cast<RenderFullScreen*>(object);

+DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderFullScreen, isRenderFullScreen());

-// This will catch anyone doing an unnecessary cast:

-void toRenderFullScreen(RenderFullScreen*);

}

#endif

« no previous file with comments | « Source/core/rendering/RenderFrameSet.h ('k') | Source/core/rendering/RenderGrid.h » ('j') | no next file with comments »