Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: Source/platform/exported/WebSpeechSynthesizerClientImpl.h

Issue 339823003: Oilpan: move platform speech objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Mixins by default Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/exported/WebSpeechSynthesizerClientImpl.h
diff --git a/Source/platform/exported/WebSpeechSynthesizerClientImpl.h b/Source/platform/exported/WebSpeechSynthesizerClientImpl.h
index 022aeaba98677e5f030b00bbb68b4b6e0f2e2bd7..de3870e44938c048361a5d4f61dc9ec2d78f85de 100644
--- a/Source/platform/exported/WebSpeechSynthesizerClientImpl.h
+++ b/Source/platform/exported/WebSpeechSynthesizerClientImpl.h
@@ -26,19 +26,18 @@
#ifndef WebSpeechSynthesizerClientImpl_h
#define WebSpeechSynthesizerClientImpl_h
+#include "platform/heap/Handle.h"
#include "platform/speech/PlatformSpeechSynthesizer.h"
#include "public/platform/WebSpeechSynthesisUtterance.h"
#include "public/platform/WebSpeechSynthesisVoice.h"
#include "public/platform/WebSpeechSynthesizerClient.h"
-#include "wtf/HashMap.h"
-#include "wtf/Vector.h"
namespace WebCore {
class PlatformSpeechSynthesizer;
class PlatformSpeechSynthesizerClient;
-class WebSpeechSynthesizerClientImpl : public blink::WebSpeechSynthesizerClient {
+class WebSpeechSynthesizerClientImpl FINAL : public GarbageCollectedFinalized<WebSpeechSynthesizerClientImpl>, public blink::WebSpeechSynthesizerClient {
public:
explicit WebSpeechSynthesizerClientImpl(PlatformSpeechSynthesizer*, PlatformSpeechSynthesizerClient*);
haraken 2014/06/17 09:18:50 Drop explicit.
sof 2014/06/17 10:42:09 Now gone.
virtual ~WebSpeechSynthesizerClientImpl();
@@ -52,9 +51,11 @@ public:
virtual void wordBoundaryEventOccurred(const blink::WebSpeechSynthesisUtterance&, unsigned charIndex);
virtual void sentenceBoundaryEventOccurred(const blink::WebSpeechSynthesisUtterance&, unsigned charIndex);
+ void trace(Visitor*);
+
private:
- PlatformSpeechSynthesizer* m_synthesizer;
- PlatformSpeechSynthesizerClient* m_client;
+ Member<PlatformSpeechSynthesizer> m_synthesizer;
+ Member<PlatformSpeechSynthesizerClient> m_client;
};
} // namespace WebCore

Powered by Google App Engine
This is Rietveld 408576698