Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 339803004: Introduce QUIC_VERSION_20: allowing endpoints to set different (Closed)

Created:
6 years, 6 months ago by ramant (doing other things)
Modified:
6 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, avd, wtc
Project:
chromium
Visibility:
Public.

Description

Introduce QUIC_VERSION_20: allowing endpoints to set different stream/session flow control windows. Two new tags kSFCW, kCFCW for stream flow control window and session (connection) flow control windows respectively. kIFCW is still used for older versions <= QUIC_VERSION_19. kIFCW has the same value as kCFCW. Most of this CL is copy/paste code for setting/getting the new tags. New values are set in quic_client_bin.cc (and quic_stream_factory.cc), and processed in quic_session.cc and reliable_quic_stream.cc rtenneti: When merging into Chromium, you should add something like: config.SetInitialStreamFlowControlWindowToSend(kInitialReceiveWindow); config.SetInitialSessionFlowControlWindowToSend(kInitialReceiveWindow); just before *session = new QuicClientSession(...) in quic_stream_factory.cc Introduce QUIC_VERSION_20: allowing endpoints to set different stream/session flow control windows. Merge internal change: 69557631 R=rch@chromium.org, rjshade@google.com

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+470 lines, -77 lines) Patch
M net/quic/crypto/crypto_handshake_message.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/crypto/crypto_protocol.h View 1 chunk +5 lines, -1 line 0 comments Download
M net/quic/quic_config.h View 3 chunks +28 lines, -1 line 0 comments Download
M net/quic/quic_config.cc View 5 chunks +63 lines, -1 line 0 comments Download
M net/quic/quic_config_test.cc View 6 chunks +35 lines, -6 lines 0 comments Download
M net/quic/quic_end_to_end_unittest.cc View 1 chunk +5 lines, -1 line 0 comments Download
M net/quic/quic_flow_controller_test.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M net/quic/quic_protocol.h View 3 chunks +5 lines, -3 lines 0 comments Download
M net/quic/quic_protocol.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M net/quic/quic_session.cc View 2 chunks +41 lines, -12 lines 0 comments Download
M net/quic/quic_session_test.cc View 8 chunks +69 lines, -17 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/reliable_quic_stream.cc View 2 chunks +32 lines, -8 lines 0 comments Download
M net/quic/reliable_quic_stream_test.cc View 2 chunks +3 lines, -1 line 0 comments Download
M net/quic/test_tools/mock_quic_dispatcher.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/quic/test_tools/quic_config_peer.h View 1 chunk +7 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_config_peer.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +4 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 1 chunk +6 lines, -1 line 0 comments Download
M net/tools/quic/end_to_end_test.cc View 5 chunks +104 lines, -3 lines 0 comments Download
M net/tools/quic/quic_client_bin.cc View 3 chunks +17 lines, -5 lines 0 comments Download
M net/tools/quic/quic_client_session_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/quic/quic_server_session_test.cc View 1 chunk +6 lines, -1 line 0 comments Download
M net/tools/quic/quic_spdy_client_stream_test.cc View 1 chunk +5 lines, -1 line 0 comments Download
M net/tools/quic/quic_spdy_server_stream_test.cc View 1 chunk +5 lines, -1 line 0 comments Download
M net/tools/quic/test_tools/mock_quic_dispatcher.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/quic/test_tools/quic_test_utils.h View 1 chunk +4 lines, -1 line 0 comments Download
M net/tools/quic/test_tools/quic_test_utils.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
6 years, 6 months ago (2014-06-19 22:13:26 UTC) #1
Ryan Hamilton
6 years, 6 months ago (2014-06-19 23:55:15 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698