Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 339793007: Revert of ozone: gpu: Add plumbing for platform-specific gpu messaging (Closed)

Created:
6 years, 6 months ago by chrishtr
Modified:
6 years, 6 months ago
CC:
chromium-reviews, rjkroege, ozone-reviews_chromium.org, jam, darin-cc_chromium.org, piman+watch_chromium.org, kalyank
Project:
chromium
Visibility:
Public.

Description

Revert of ozone: gpu: Add plumbing for platform-specific gpu messaging (https://codereview.chromium.org/338193003/) Reason for revert: Suspect it is causing a failure of webgl_conformance_tests for this bot: http://build.chromium.org/p/chromium.gpu/builders/Win7%20Release%20(Intel)/builds/15425 Original issue's description: > ozone: gpu: Add plumbing for platform-specific gpu messaging > > ChromeOS without X11 will do display configuration and cursor > movement from the GPU process. This is the conduit for the messages > needed to make this work. > > This plumbing also supports other platforms with similar requirements > (e.g. wayland's port). X11 does not need any specific messaging here, > since we just call the X server from the browser. > > BUG=377497 > TEST=content_shell --ozone-platform=egltest > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278465 TBR=piman@chromium.org,rjkroege@chromium.org,alexst@chromium.org,spang@chromium.org NOTREECHECKS=true NOTRY=true BUG=377497 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278492

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -240 lines) Patch
M content/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/gpu/gpu_process_host_ui_shim.cc View 4 chunks +0 lines, -23 lines 0 comments Download
M content/content_common.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
M content/gpu/gpu_child_thread.cc View 3 chunks +0 lines, -18 lines 0 comments Download
D ui/ozone/gpu/gpu_platform_support.h View 1 chunk +0 lines, -31 lines 0 comments Download
D ui/ozone/gpu/gpu_platform_support.cc View 1 chunk +0 lines, -34 lines 0 comments Download
D ui/ozone/gpu/gpu_platform_support_host.h View 1 chunk +0 lines, -40 lines 0 comments Download
D ui/ozone/gpu/gpu_platform_support_host.cc View 1 chunk +0 lines, -37 lines 0 comments Download
M ui/ozone/ozone.gyp View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/ozone/ozone_platform.h View 2 chunks +0 lines, -4 lines 0 comments Download
M ui/ozone/platform/caca/ozone_platform_caca.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/ozone/platform/dri/ozone_platform_dri.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/ozone/platform/dri/ozone_platform_gbm.cc View 4 chunks +0 lines, -13 lines 0 comments Download
M ui/ozone/platform/egltest/ozone_platform_egltest.cc View 4 chunks +0 lines, -12 lines 0 comments Download
M ui/ozone/platform/test/ozone_platform_test.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
chrishtr
Created Revert of ozone: gpu: Add plumbing for platform-specific gpu messaging
6 years, 6 months ago (2014-06-19 21:32:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/339793007/1
6 years, 6 months ago (2014-06-19 21:33:47 UTC) #2
commit-bot: I haz the power
Change committed as 278492
6 years, 6 months ago (2014-06-19 21:36:55 UTC) #3
spang
6 years, 6 months ago (2014-06-20 14:51:16 UTC) #4
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/341253002/ by spang@chromium.org.

The reason for reverting is: This cannot have broken the !ozone build..

Powered by Google App Engine
This is Rietveld 408576698