Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 339793006: Remove unnecessary Document.h includes in .cpp files (Closed)

Created:
6 years, 6 months ago by philipj_slow
Modified:
6 years, 6 months ago
CC:
abarth-chromium, alecflett+watch_chromium.org, darktears, apavlov+blink_chromium.org, arv+blink, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-bindings_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-rendering, Inactive, dglazkov+blink, krit, dstockwell, eae+blinkwatch, ed+blinkwatch_opera.com, eric.carlson_apple.com, Eric Willigers, falken, f(malita), fs, gavinp+loader_chromium.org, gavinp+prerender_chromium.org, gasubic, gyuyoung.kim_webkit.org, horo+watch_chromium.org, Nate Chapin, jchaffraix+rendering, jsbell+serviceworker_chromium.org, kinuko+serviceworker, kinuko+fileapi, kouhei+svg_chromium.org, leviw+renderwatch, michaeln, Mike Lawther (Google), mvanouwerkerk+watch_chromium.org, nhiroki, pdr., rjwright, rwlbuis, Raymond Toy, rune+blink, Stephen Chennney, serviceworker-reviews, shans, sof, nessy, Steve Block, Timothy Loh, timvolodine, tzik, vcarbune.chromium, zoltan1
Project:
blink
Visibility:
Public.

Description

Remove unnecessary Document.h includes in .cpp files This change was made by removing the include everywhere, and then restoring semi-manually until everything compiled again. This gives a small reduction in recompilation when touching Document.h, from 1100 to 1074 steps locally. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176867

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : release compile fix #

Patch Set 5 : rebase #

Patch Set 6 : rebase #

Patch Set 7 : fix oilpan #

Patch Set 8 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -54 lines) Patch
M Source/bindings/v8/V8ErrorHandler.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/v8/custom/V8XSLTProcessorCustom.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSFontFace.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/MediaValuesDynamic.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/ActiveDOMObjectTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/DocumentLifecycleNotifier.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/MainThreadTaskRunner.cpp View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/dom/MessagePort.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/MutationObserver.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/NamedNodeMap.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/StyleSheetScopingNodeList.cpp View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/TreeScopeAdopter.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/AppendNodeCommand.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/DeleteFromTextNodeCommand.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/FormatBlockCommand.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/InsertNodeBeforeCommand.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/events/DOMWindowEventQueue.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/fetch/MemoryCache.cpp View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/ConsoleBase.cpp View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/DOMWindowProperty.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/FrameConsole.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLOptGroupElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLQuoteElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/loader/BeaconLoader.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/page/DragData.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/page/PageAnimator.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/FilterEffectRenderer.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderButton.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderCounter.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderListMarker.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderTableRow.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGCursorElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGFitToViewBox.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGParserUtilities.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGPolyElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGScriptElement.cpp View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGViewSpec.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/xml/DocumentXPathEvaluator.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/xml/XMLSerializer.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/device_orientation/DeviceOrientationInspectorAgent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/push_messaging/NavigatorPushManager.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/quota/DOMWindowQuota.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/quota/DeprecatedStorageInfo.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/screen_orientation/ScreenOrientationController.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainer.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/ScriptProcessorNode.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webdatabase/Database.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/PrerendererClientImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/tests/RenderTableCellTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/tests/RenderTableRowTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/tests/WebDocumentTest.cpp View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/tests/WebPageNewSerializerTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/tests/WebPageSerializerTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 23 (0 generated)
philipj_slow
release compile fix
6 years, 6 months ago (2014-06-20 20:12:16 UTC) #1
philipj_slow
6 years, 6 months ago (2014-06-20 20:50:34 UTC) #2
philipj_slow
ping
6 years, 6 months ago (2014-06-23 21:01:33 UTC) #3
philipj_slow
rebase
6 years, 6 months ago (2014-06-23 21:13:15 UTC) #4
jochen (gone - plz use gerrit)
lgtm
6 years, 6 months ago (2014-06-24 08:57:55 UTC) #5
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 6 months ago (2014-06-24 11:40:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/339793006/100001
6 years, 6 months ago (2014-06-24 11:41:34 UTC) #7
philipj_slow
The CQ bit was unchecked by philipj@opera.com
6 years, 6 months ago (2014-06-24 11:50:15 UTC) #8
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 6 months ago (2014-06-24 12:47:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/339793006/120001
6 years, 6 months ago (2014-06-24 12:48:09 UTC) #10
philipj_slow
The CQ bit was unchecked by philipj@opera.com
6 years, 6 months ago (2014-06-24 13:59:06 UTC) #11
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 6 months ago (2014-06-24 15:05:01 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/339793006/120001
6 years, 6 months ago (2014-06-24 15:06:02 UTC) #13
philipj_slow
The CQ bit was unchecked by philipj@opera.com
6 years, 6 months ago (2014-06-24 15:28:57 UTC) #14
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 6 months ago (2014-06-24 17:35:28 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/339793006/120001
6 years, 6 months ago (2014-06-24 17:36:21 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-24 17:36:36 UTC) #17
commit-bot: I haz the power
Failed to apply patch for Source/core/html/track/TextTrack.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 6 months ago (2014-06-24 17:36:37 UTC) #18
philipj_slow
rebase
6 years, 6 months ago (2014-06-24 17:38:34 UTC) #19
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 6 months ago (2014-06-24 17:38:52 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/339793006/140001
6 years, 6 months ago (2014-06-24 17:39:19 UTC) #21
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-24 19:15:09 UTC) #22
commit-bot: I haz the power
6 years, 6 months ago (2014-06-24 19:40:03 UTC) #23
Message was sent while issue was closed.
Change committed as 176867

Powered by Google App Engine
This is Rietveld 408576698