src/llvm2ice.cpp - Issue 339783002: Add support for undef values in ICE IR.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/llvm2ice.cpp

Issue 339783002: Add support for undef values in ICE IR. (Closed) Base URL: https://gerrit.chromium.org/gerrit/p/native_client/pnacl-subzero.git@master

Patch Set: Comment about uninitialized registers Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/llvm2ice.cpp

diff --git a/src/llvm2ice.cpp b/src/llvm2ice.cpp

index 374d753769eff6b00403fb787bd52ce49430a428..bce8c94a2a538fa283994cf303b1657b1d84054e 100644

--- a/src/llvm2ice.cpp

+++ b/src/llvm2ice.cpp

@@ -117,6 +117,8 @@ public:

return Ctx->getConstantDouble(CFP->getValueAPF().convertToDouble());

llvm_unreachable("Unexpected floating point type");

return NULL;

+ } else if (const UndefValue *CU = dyn_cast<UndefValue>(Const)) {

+ return Ctx->getConstantUndef(convertType(CU->getType()));

} else {

llvm_unreachable("Unhandled constant type");

return NULL;

« no previous file with comments | « src/IceTargetLoweringX8632.cpp ('k') | tests_lit/llvm2ice_tests/undef.ll » ('j') | no next file with comments »