Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 339763003: Revert of Clear SDCH information on "Clear browsing data" path. (Closed)

Created:
6 years, 6 months ago by Sorin Jianu
Modified:
6 years, 6 months ago
CC:
chromium-reviews, markusheintz_, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Revert of Clear SDCH information on "Clear browsing data" path. (https://codereview.chromium.org/321283002/) Reason for revert: Fails ASAN tests: (view as text) SdchManagerTest.ClearDictionaryData (run #1): [ RUN ] SdchManagerTest.ClearDictionaryData [ OK ] SdchManagerTest.ClearDictionaryData (0 ms) [----------] 1 test from SdchManagerTest (0 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test case ran. (2 ms total) [ PASSED ] 1 test. YOU HAVE 107 DISABLED TESTS ================================================================= ==16633==ERROR: LeakSanitizer: detected memory leaks Direct leak of 192 byte(s) in 1 object(s) allocated from: #0 0x51301b in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:55 #1 0x34c6174 in net::SdchManager::AddSdchDictionary(std::string const&, GURL const&) net/base/sdch_manager.cc:469 #2 0x808536 in net::SdchManagerTest_ClearDictionaryData_Test::TestBody() net/base/sdch_manager_unittest.cc:454 #3 0x33173a8 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045 #4 0x33173a8 in testing::Test::Run() testing/gtest/src/gtest.cc:2061 #5 0x3319b89 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237 #6 0x331a916 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344 #7 0x332da2a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065 #8 0x332d060 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045 #9 0x332d060 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697 <truncated, full output is in gzipped JSON output at end of step> #5 0x7eff91b98391 in std::string::append(unsigned long, char) /build/buildd/gcc-4.6-4.6.3/build/x86_64-linux-gnu/libstdc++-v3/include/bits/basic_string.tcc:290 #6 0x7eff91b97aeb in std::string::resize(unsigned long, char) /build/buildd/gcc-4.6-4.6.3/build/x86_64-linux-gnu/libstdc++-v3/include/bits/basic_string.tcc:647 #7 0x31f1b12 in resize /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/basic_string.h:749 #8 0x31f1b12 in base::Base64Encode(base::BasicStringPiece\u003Cstd::string> const&, std::string*) base/base64.cc:13 #9 0x34c73d5 in net::SdchManager::UrlSafeBase64Encode(std::string const&, std::string*) net/base/sdch_manager.cc:558 #10 0x34c67e7 in net::SdchManager::GenerateHash(std::string const&, std::string*, std::string*) net/base/sdch_manager.cc:524 #11 0x34c519b in net::SdchManager::AddSdchDictionary(std::string const&, GURL const&) net/base/sdch_manager.cc:380 #12 0x808536 in net::SdchManagerTest_ClearDictionaryData_Test::TestBody() net/base/sdch_manager_unittest.cc:454 #13 0x33173a8 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045 #14 0x33173a8 in testing::Test::Run() testing/gtest/src/gtest.cc:2061 #15 0x3319b89 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237 #16 0x331a916 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344 #17 0x332da2a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065 #18 0x332d060 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045 #19 0x332d060 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697 #20 0x3fc8ddc in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231 #21 0x3fc8ddc in base::TestSuite::Run() base/test/test_suite.cc:227 #22 0x3fbd5a2 in Run base/callback.h:401 #23 0x3fbd5a2 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback\u003Cint ()> const&, int, bool, base::Callback\u003Cvoid ()> const&) base/test/launcher/unit_test_launcher.cc:498 #24 0x3fbcf1d in base::LaunchUnitTests(int, char**, base::Callback\u003Cint ()> const&) base/test/launcher/unit_test_launcher.cc:553 #25 0x2ae277c in main net/test/run_all_unittests.cc:64 #26 0x7eff9152d76c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 SUMMARY: AddressSanitizer: 449 byte(s) leaked in 5 allocation(s). SdchManagerTest.ClearDictionaryData (run #2): [ RUN ] SdchManagerTest.ClearDictionaryData [ OK ] SdchManagerTest.ClearDictionaryData (1 ms) [----------] 1 test from SdchManagerTest (1 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test case ran. (1 ms total) [ PASSED ] 1 test. YOU HAVE 107 DISABLED TESTS ================================================================= ==3818==ERROR: LeakSanitizer: detected memory leaks Direct leak of 192 byte(s) in 1 object(s) allocated from: #0 0x51301b in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:55 #1 0x34c6174 in net::SdchManager::AddSdchDictionary(std::string const&, GURL const&) net/base/sdch_manager.cc:469 #2 0x808536 in net::SdchManagerTest_ClearDictionaryData_Test::TestBody() net/base/sdch_manager_unittest.cc:454 #3 0x33173a8 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045 #4 0x33173a8 in testing::Test::Run() testing/gtest/src/gtest.cc:2061 #5 0x3319b89 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237 #6 0x331a916 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344 #7 0x332da2a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065 #8 0x332d060 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045 #9 0x332d060 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697 <truncated, full output is in gzipped JSON output at end of step> #5 0x7ffa92ba6391 in std::string::append(unsigned long, char) /build/buildd/gcc-4.6-4.6.3/build/x86_64-linux-gnu/libstdc++-v3/include/bits/basic_string.tcc:290 #6 0x7ffa92ba5aeb in std::string::resize(unsigned long, char) /build/buildd/gcc-4.6-4.6.3/build/x86_64-linux-gnu/libstdc++-v3/include/bits/basic_string.tcc:647 #7 0x31f1b12 in resize /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/basic_string.h:749 #8 0x31f1b12 in base::Base64Encode(base::BasicStringPiece\u003Cstd::string> const&, std::string*) base/base64.cc:13 #9 0x34c73d5 in net::SdchManager::UrlSafeBase64Encode(std::string const&, std::string*) net/base/sdch_manager.cc:558 #10 0x34c67e7 in net::SdchManager::GenerateHash(std::string const&, std::string*, std::string*) net/base/sdch_manager.cc:524 #11 0x34c519b in net::SdchManager::AddSdchDictionary(std::string const&, GURL const&) net/base/sdch_manager.cc:380 #12 0x808536 in net::SdchManagerTest_ClearDictionaryData_Test::TestBody() net/base/sdch_manager_unittest.cc:454 #13 0x33173a8 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045 #14 0x33173a8 in testing::Test::Run() testing/gtest/src/gtest.cc:2061 #15 0x3319b89 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237 #16 0x331a916 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344 #17 0x332da2a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065 #18 0x332d060 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045 #19 0x332d060 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697 #20 0x3fc8ddc in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231 #21 0x3fc8ddc in base::TestSuite::Run() base/test/test_suite.cc:227 #22 0x3fbd5a2 in Run base/callback.h:401 #23 0x3fbd5a2 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback\u003Cint ()> const&, int, bool, base::Callback\u003Cvoid ()> const&) base/test/launcher/unit_test_launcher.cc:498 #24 0x3fbcf1d in base::LaunchUnitTests(int, char**, base::Callback\u003Cint ()> const&) base/test/launcher/unit_test_launcher.cc:553 #25 0x2ae277c in main net/test/run_all_unittests.cc:64 #26 0x7ffa9253b76c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 SUMMARY: AddressSanitizer: 449 byte(s) leaked in 5 allocation(s). SdchManagerTest.ClearDictionaryData (run #3): [ RUN ] SdchManagerTest.ClearDictionaryData [ OK ] SdchManagerTest.ClearDictionaryData (0 ms) [----------] 1 test from SdchManagerTest (1 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test case ran. (1 ms total) [ PASSED ] 1 test. YOU HAVE 107 DISABLED TESTS ================================================================= ==3824==ERROR: LeakSanitizer: detected memory leaks Direct leak of 192 byte(s) in 1 object(s) allocated from: #0 0x51301b in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:55 #1 0x34c6174 in net::SdchManager::AddSdchDictionary(std::string const&, GURL const&) net/base/sdch_manager.cc:469 #2 0x808536 in net::SdchManagerTest_ClearDictionaryData_Test::TestBody() net/base/sdch_manager_unittest.cc:454 #3 0x33173a8 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045 #4 0x33173a8 in testing::Test::Run() testing/gtest/src/gtest.cc:2061 #5 0x3319b89 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237 #6 0x331a916 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344 #7 0x332da2a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065 #8 0x332d060 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045 #9 0x332d060 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697 <truncated, full output is in gzipped JSON output at end of step> #5 0x7f8ff892e391 in std::string::append(unsigned long, char) /build/buildd/gcc-4.6-4.6.3/build/x86_64-linux-gnu/libstdc++-v3/include/bits/basic_string.tcc:290 #6 0x7f8ff892daeb in std::string::resize(unsigned long, char) /build/buildd/gcc-4.6-4.6.3/build/x86_64-linux-gnu/libstdc++-v3/include/bits/basic_string.tcc:647 #7 0x31f1b12 in resize /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/basic_string.h:749 #8 0x31f1b12 in base::Base64Encode(base::BasicStringPiece\u003Cstd::string> const&, std::string*) base/base64.cc:13 #9 0x34c73d5 in net::SdchManager::UrlSafeBase64Encode(std::string const&, std::string*) net/base/sdch_manager.cc:558 #10 0x34c67e7 in net::SdchManager::GenerateHash(std::string const&, std::string*, std::string*) net/base/sdch_manager.cc:524 #11 0x34c519b in net::SdchManager::AddSdchDictionary(std::string const&, GURL const&) net/base/sdch_manager.cc:380 #12 0x808536 in net::SdchManagerTest_ClearDictionaryData_Test::TestBody() net/base/sdch_manager_unittest.cc:454 #13 0x33173a8 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045 #14 0x33173a8 in testing::Test::Run() testing/gtest/src/gtest.cc:2061 #15 0x3319b89 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237 #16 0x331a916 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344 #17 0x332da2a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065 #18 0x332d060 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045 #19 0x332d060 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697 #20 0x3fc8ddc in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231 #21 0x3fc8ddc in base::TestSuite::Run() base/test/test_suite.cc:227 #22 0x3fbd5a2 in Run base/callback.h:401 #23 0x3fbd5a2 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback\u003Cint ()> const&, int, bool, base::Callback\u003Cvoid ()> const&) base/test/launcher/unit_test_launcher.cc:498 #24 0x3fbcf1d in base::LaunchUnitTests(int, char**, base::Callback\u003Cint ()> const&) base/test/launcher/unit_test_launcher.cc:553 #25 0x2ae277c in main net/test/run_all_unittests.cc:64 #26 0x7f8ff82c376c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 SUMMARY: AddressSanitizer: 449 byte(s) leaked in 5 allocation(s). SdchManagerTest.ClearDictionaryData (run #4): [ RUN ] SdchManagerTest.ClearDictionaryData [ OK ] SdchManagerTest.ClearDictionaryData (1 ms) [----------] 1 test from SdchManagerTest (1 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test case ran. (1 ms total) [ PASSED ] 1 test. YOU HAVE 107 DISABLED TESTS ================================================================= ==3827==ERROR: LeakSanitizer: detected memory leaks Direct leak of 192 byte(s) in 1 object(s) allocated from: #0 0x51301b in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:55 #1 0x34c6174 in net::SdchManager::AddSdchDictionary(std::string const&, GURL const&) net/base/sdch_manager.cc:469 #2 0x808536 in net::SdchManagerTest_ClearDictionaryData_Test::TestBody() net/base/sdch_manager_unittest.cc:454 #3 0x33173a8 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045 #4 0x33173a8 in testing::Test::Run() testing/gtest/src/gtest.cc:2061 #5 0x3319b89 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237 #6 0x331a916 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344 #7 0x332da2a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065 #8 0x332d060 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045 #9 0x332d060 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697 <truncated, full output is in gzipped JSON output at end of step> #5 0x7ff270a3c391 in std::string::append(unsigned long, char) /build/buildd/gcc-4.6-4.6.3/build/x86_64-linux-gnu/libstdc++-v3/include/bits/basic_string.tcc:290 #6 0x7ff270a3baeb in std::string::resize(unsigned long, char) /build/buildd/gcc-4.6-4.6.3/build/x86_64-linux-gnu/libstdc++-v3/include/bits/basic_string.tcc:647 #7 0x31f1b12 in resize /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/basic_string.h:749 #8 0x31f1b12 in base::Base64Encode(base::BasicStringPiece\u003Cstd::string> const&, std::string*) base/base64.cc:13 #9 0x34c73d5 in net::SdchManager::UrlSafeBase64Encode(std::string const&, std::string*) net/base/sdch_manager.cc:558 #10 0x34c67e7 in net::SdchManager::GenerateHash(std::string const&, std::string*, std::string*) net/base/sdch_manager.cc:524 #11 0x34c519b in net::SdchManager::AddSdchDictionary(std::string const&, GURL const&) net/base/sdch_manager.cc:380 #12 0x808536 in net::SdchManagerTest_ClearDictionaryData_Test::TestBody() net/base/sdch_manager_unittest.cc:454 #13 0x33173a8 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045 #14 0x33173a8 in testing::Test::Run() testing/gtest/src/gtest.cc:2061 #15 0x3319b89 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237 #16 0x331a916 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344 #17 0x332da2a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065 #18 0x332d060 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045 #19 0x332d060 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697 #20 0x3fc8ddc in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231 #21 0x3fc8ddc in base::TestSuite::Run() base/test/test_suite.cc:227 #22 0x3fbd5a2 in Run base/callback.h:401 #23 0x3fbd5a2 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback\u003Cint ()> const&, int, bool, base::Callback\u003Cvoid ()> const&) base/test/launcher/unit_test_launcher.cc:498 #24 0x3fbcf1d in base::LaunchUnitTests(int, char**, base::Callback\u003Cint ()> const&) base/test/launcher/unit_test_launcher.cc:553 #25 0x2ae277c in main net/test/run_all_unittests.cc:64 #26 0x7ff2703d176c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 SUMMARY: AddressSanitizer: 449 byte(s) leaked in 5 allocation(s). Original issue's description: > Clear SDCH information on "Clear browsing data" path. > > BUG=370567 > BUG=327783 > R=jar@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277607 TBR=jar@chromium.org,sky@chromium.org,rdsmith@chromium.org NOTREECHECKS=true NOTRY=true BUG=370567 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277624

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -89 lines) Patch
M chrome/browser/browsing_data/browsing_data_remover.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/net/sdch_dictionary_fetcher.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/net/sdch_dictionary_fetcher.cc View 2 chunks +0 lines, -14 lines 0 comments Download
M net/base/sdch_manager.h View 3 chunks +1 line, -9 lines 0 comments Download
M net/base/sdch_manager.cc View 4 chunks +7 lines, -21 lines 0 comments Download
M net/base/sdch_manager_unittest.cc View 1 chunk +0 lines, -33 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Sorin Jianu
Created Revert of Clear SDCH information on "Clear browsing data" path.
6 years, 6 months ago (2014-06-17 02:12:29 UTC) #1
Sorin Jianu
The CQ bit was unchecked by sorin@chromium.org
6 years, 6 months ago (2014-06-17 02:15:53 UTC) #2
Sorin Jianu
The CQ bit was checked by sorin@chromium.org
6 years, 6 months ago (2014-06-17 02:17:42 UTC) #3
Randy Smith (Not in Mondays)
LGTM.
6 years, 6 months ago (2014-06-17 02:17:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sorin@chromium.org/339763003/1
6 years, 6 months ago (2014-06-17 02:19:34 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 02:24:02 UTC) #6
Message was sent while issue was closed. 
Change committed as 277624

Powered by Google App Engine
This is Rietveld 408576698