Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1198)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 339763002: Make TypedList not implement ByteBuffer. (Closed)

Created:
6 years, 6 months ago by Cutch
Modified:
6 years, 6 months ago
Reviewers:
srdjan, siva, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Make TypedList not implement ByteBuffer. BUG=https://code.google.com/p/dart/issues/detail?id=10136 R=asiva@google.com, iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=37397

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -55 lines) Patch
M runtime/lib/typed_data.dart View 1 7 chunks +29 lines, -13 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/snapshot_test.cc View 1 chunk +33 lines, -33 lines 0 comments Download
M runtime/vm/symbols.h View 1 chunk +1 line, -0 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/standalone/io/file_typed_data_test.dart View 6 chunks +12 lines, -6 lines 0 comments Download
M tests/standalone/typed_data_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Cutch
6 years, 6 months ago (2014-06-16 22:09:14 UTC) #1
srdjan
DBC https://codereview.chromium.org/339763002/diff/1/tests/co19/co19-runtime.status File tests/co19/co19-runtime.status (right): https://codereview.chromium.org/339763002/diff/1/tests/co19/co19-runtime.status#newcode51 tests/co19/co19-runtime.status:51: LibTest/typed_data/Int64List/buffer_A01_t01: Skip # co19 issue 694 Can this ...
6 years, 6 months ago (2014-06-17 00:10:35 UTC) #2
Ivan Posva
LGTM -ip https://codereview.chromium.org/339763002/diff/1/runtime/lib/typed_data.dart File runtime/lib/typed_data.dart (right): https://codereview.chromium.org/339763002/diff/1/runtime/lib/typed_data.dart#newcode2533 runtime/lib/typed_data.dart:2533: : _typedData = _buffer._data, // This assignment ...
6 years, 6 months ago (2014-06-17 01:07:03 UTC) #3
siva
https://codereview.chromium.org/339763002/diff/1/runtime/lib/typed_data.dart File runtime/lib/typed_data.dart (right): https://codereview.chromium.org/339763002/diff/1/runtime/lib/typed_data.dart#newcode624 runtime/lib/typed_data.dart:624: bool operator==(Object other) => identical(_data, other._data); shouldn't this say ...
6 years, 6 months ago (2014-06-17 01:09:57 UTC) #4
siva
LGTM otherwise
6 years, 6 months ago (2014-06-17 01:10:16 UTC) #5
Cutch
https://codereview.chromium.org/339763002/diff/1/runtime/lib/typed_data.dart File runtime/lib/typed_data.dart (right): https://codereview.chromium.org/339763002/diff/1/runtime/lib/typed_data.dart#newcode624 runtime/lib/typed_data.dart:624: bool operator==(Object other) => identical(_data, other._data); On 2014/06/17 01:09:57, ...
6 years, 6 months ago (2014-06-17 14:31:17 UTC) #6
Cutch
6 years, 6 months ago (2014-06-17 14:34:52 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 manually as r37397 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698