Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 339753002: Remove RenderImage::styleDidChange. (Closed)

Created:
6 years, 6 months ago by jbroman
Modified:
6 years, 6 months ago
Reviewers:
esprehn, ojan
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Remove RenderImage::styleDidChange. This simply calls its superclass since about four months ago. https://codereview.chromium.org/129873009/ Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176260

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M Source/core/rendering/RenderImage.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderImage.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jbroman
This looks trivial (and has been for months); any reason to keep this around?
6 years, 6 months ago (2014-06-16 21:02:42 UTC) #1
esprehn
lgtm
6 years, 6 months ago (2014-06-16 21:03:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/339753002/1
6 years, 6 months ago (2014-06-16 21:03:46 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-16 23:22:36 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/12325)
6 years, 6 months ago (2014-06-16 23:22:38 UTC) #5
jbroman
The CQ bit was checked by jbroman@chromium.org
6 years, 6 months ago (2014-06-17 00:58:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/339753002/1
6 years, 6 months ago (2014-06-17 00:58:41 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 00:59:12 UTC) #8
Message was sent while issue was closed.
Change committed as 176260

Powered by Google App Engine
This is Rietveld 408576698