Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 339743004: Add Tracing.getCategories to devtools_tracing_handler.cc. (Closed)

Created:
6 years, 6 months ago by chrishenry
Modified:
6 years, 6 months ago
Reviewers:
nduca, pfeldman
CC:
aandrey+blink_chromium.org, chromium-reviews, darin-cc_chromium.org, devtools-reviews_chromium.org, jam, paulirish+reviews_chromium.org, vsevik, yurys
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add Tracing.getCategories to devtools_tracing_handler.cc. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279161

Patch Set 1 #

Patch Set 2 : Address review comment. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
M content/browser/devtools/devtools_tracing_handler.h View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M content/browser/devtools/devtools_tracing_handler.cc View 1 2 2 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
chrishenry
6 years, 6 months ago (2014-06-17 17:24:20 UTC) #1
chrishenry
Please hold off on reviewing this. I tested using a wrong build.
6 years, 6 months ago (2014-06-17 18:26:49 UTC) #2
chrishenry
Actually this works just fine. The problem is in tracing JS.
6 years, 6 months ago (2014-06-17 21:05:58 UTC) #3
nduca
lgtm on my part but you'll need pfeldman or another content/browser/devtools OWNER to give you ...
6 years, 6 months ago (2014-06-18 16:38:15 UTC) #4
pfeldman
lgtm. please make sure the order of methods in .cc matches the one of .h
6 years, 6 months ago (2014-06-18 17:03:20 UTC) #5
chrishenry
The .h and .cc already doesn't seem to be in sync. Shall I follow up ...
6 years, 6 months ago (2014-06-18 17:16:17 UTC) #6
pfeldman
Not making things worse with this patch is enough. I.e. grouping handlers together would be ...
6 years, 6 months ago (2014-06-18 17:21:49 UTC) #7
chrishenry
The CQ bit was checked by chrishenry@google.com
6 years, 6 months ago (2014-06-20 21:16:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishenry@google.com/339743004/40001
6 years, 6 months ago (2014-06-20 21:25:06 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-21 06:59:55 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-21 07:58:27 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/20345)
6 years, 6 months ago (2014-06-21 07:58:28 UTC) #12
chrishenry
The CQ bit was checked by chrishenry@google.com
6 years, 6 months ago (2014-06-23 18:26:29 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishenry@google.com/339743004/40001
6 years, 6 months ago (2014-06-23 18:27:51 UTC) #14
commit-bot: I haz the power
6 years, 6 months ago (2014-06-23 19:23:03 UTC) #15
Message was sent while issue was closed.
Change committed as 279161

Powered by Google App Engine
This is Rietveld 408576698