Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: media/cast/sender/video_encoder_impl_unittest.cc

Issue 339743002: Cast: Make vp8 3-buffer mode work (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merged, comment updated Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/cast/sender/video_encoder_impl_unittest.cc
diff --git a/media/cast/sender/video_encoder_impl_unittest.cc b/media/cast/sender/video_encoder_impl_unittest.cc
index 010798ed676864b507693ff26c8642067eb78eb0..b4c54540e602b38bb4ef8f822256b115aa820781 100644
--- a/media/cast/sender/video_encoder_impl_unittest.cc
+++ b/media/cast/sender/video_encoder_impl_unittest.cc
@@ -36,15 +36,14 @@ class TestVideoEncoderCallback
void DeliverEncodedVideoFrame(
scoped_ptr<EncodedFrame> encoded_frame) {
- if (expected_frame_id_ == expected_last_referenced_frame_id_) {
- EXPECT_EQ(EncodedFrame::KEY, encoded_frame->dependency);
- } else {
+ if (expected_frame_id_ != expected_last_referenced_frame_id_) {
miu 2014/09/02 19:22:03 If this assumption is no longer true, should we be
hubbe 2014/09/02 21:39:48 I think I'm going to try to make the dependency in
EXPECT_EQ(EncodedFrame::DEPENDENT,
encoded_frame->dependency);
}
EXPECT_EQ(expected_frame_id_, encoded_frame->frame_id);
EXPECT_EQ(expected_last_referenced_frame_id_,
- encoded_frame->referenced_frame_id);
+ encoded_frame->referenced_frame_id)
+ << "frame id: " << expected_frame_id_;
EXPECT_EQ(expected_capture_time_, encoded_frame->reference_time);
}

Powered by Google App Engine
This is Rietveld 408576698