Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Unified Diff: gyp_skia

Issue 339733002: Fix Windows bots (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Address comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gyp_skia
diff --git a/gyp_skia b/gyp_skia
index 1f3f337e7e9e6e787d1a41ef4168c96ff43d9759..0b0fa7d1bd38f497cfe24a543ab12f25b13ce384 100755
--- a/gyp_skia
+++ b/gyp_skia
@@ -93,6 +93,7 @@ if __name__ == '__main__':
os.environ[ENVVAR_GYP_GENERATORS] = default_gyp_generators
print '%s is "%s"' % (ENVVAR_GYP_GENERATORS, os.getenv(ENVVAR_GYP_GENERATORS))
+ vs2013_runtime_dll_dirs = None
if os.getenv('CHROME_HEADLESS', '0') == '1':
if sys.platform.startswith('win') or sys.platform.startswith('cygwin'):
chrome_path = os.getenv('CHROME_PATH')
@@ -100,8 +101,8 @@ if __name__ == '__main__':
sys.path.append(os.path.join(chrome_path, 'build'))
sys.path.append(os.path.join(chrome_path, 'tools'))
import vs_toolchain
- vs_toolchain.Update()
- vs_toolchain.GetToolchainDir()
+ vs2013_runtime_dll_dirs = \
+ vs_toolchain.SetEnvironmentAndGetRuntimeDllDirs()
# Set CWD to the directory containing this script.
# This allows us to launch it from other directories, in spite of gyp's
@@ -157,4 +158,14 @@ if __name__ == '__main__':
print gyp_source_dir, ' '.join(args)
else:
# Off we go...
- sys.exit(gyp.main(args))
+ res = gyp.main(args)
+ if res:
+ sys.exit(res)
+
+ # This code is copied from Chrome's build/gyp_chromium. It's not clear why
+ # the *_runtime variables are reversed.
+ if vs2013_runtime_dll_dirs:
+ x64_runtime, x86_runtime = vs2013_runtime_dll_dirs
+ vs_toolchain.CopyVsRuntimeDlls(
+ os.path.join(os.getenv('CHROME_PATH'), get_output_dir()),
+ (x86_runtime, x64_runtime))
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698