Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Issue 339733002: Fix Windows bots (Closed)

Created:
6 years, 6 months ago by borenet
Modified:
6 years, 6 months ago
Reviewers:
mtklein, rmistry
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments #

Patch Set 3 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M gyp_skia View 1 2 3 chunks +14 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
borenet
6 years, 6 months ago (2014-06-16 19:09:12 UTC) #1
mtklein
https://codereview.chromium.org/339733002/diff/1/gyp_skia File gyp_skia (right): https://codereview.chromium.org/339733002/diff/1/gyp_skia#newcode164 gyp_skia:164: if vs2013_runtime_dll_dirs: Can this run before gyp? If so, ...
6 years, 6 months ago (2014-06-16 19:11:29 UTC) #2
borenet
Uploaded patch set 3. https://codereview.chromium.org/339733002/diff/1/gyp_skia File gyp_skia (right): https://codereview.chromium.org/339733002/diff/1/gyp_skia#newcode164 gyp_skia:164: if vs2013_runtime_dll_dirs: On 2014/06/16 19:11:29, ...
6 years, 6 months ago (2014-06-16 19:19:08 UTC) #3
mtklein
lgtm
6 years, 6 months ago (2014-06-16 19:19:50 UTC) #4
borenet
The CQ bit was checked by borenet@google.com
6 years, 6 months ago (2014-06-16 19:20:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/borenet@google.com/339733002/40001
6 years, 6 months ago (2014-06-16 19:21:09 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-16 20:41:31 UTC) #7
Message was sent while issue was closed.
Change committed as ad2ab61b4eec0ae43f213af3f18ffe373fe8c4aa

Powered by Google App Engine
This is Rietveld 408576698