Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: Source/bindings/v8/ScriptCallStackFactory.cpp

Issue 33973002: Fix for https://code.google.com/p/dart/issues/detail?id=5851 Proper line #s and columns for Dart er… (Closed) Base URL: svn://svn.chromium.org/multivm/trunk/webkit
Patch Set: ready to review Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/ScriptCallStackFactory.cpp
diff --git a/Source/bindings/v8/ScriptCallStackFactory.cpp b/Source/bindings/v8/ScriptCallStackFactory.cpp
index 22de5f8d8282566a7eb524c8392b7a202687caf0..98fd95dbb771371f66eb0129388ce6363ee35ca6 100644
--- a/Source/bindings/v8/ScriptCallStackFactory.cpp
+++ b/Source/bindings/v8/ScriptCallStackFactory.cpp
@@ -31,6 +31,7 @@
#include "config.h"
#include "bindings/v8/ScriptCallStackFactory.h"
+#include "bindings/dart/DartUtilities.h"
#include "bindings/v8/ScriptScope.h"
#include "bindings/v8/ScriptValue.h"
#include "bindings/v8/V8Binding.h"
@@ -116,14 +117,22 @@ PassRefPtr<ScriptCallStack> createScriptCallStackForConsole(size_t maxStackSize)
return createScriptCallStack(stackSize);
}
-PassRefPtr<ScriptCallStack> createScriptCallStackForConsole(ScriptState*)
+PassRefPtr<ScriptCallStack> createScriptCallStackForConsole(ScriptState* scriptState)
{
- return createScriptCallStackForConsole();
+ // FIXMEDART: move to a shared bindings directory.
+ if (!scriptState || scriptState->isJavaScript())
+ return createScriptCallStackForConsole();
+
+ return DartUtilities::createScriptCallStack();
}
-PassRefPtr<ScriptCallStack> createScriptCallStack(ScriptState*, size_t maxStackSize)
+PassRefPtr<ScriptCallStack> createScriptCallStack(ScriptState* scriptState, size_t maxStackSize)
{
- return createScriptCallStackForConsole(maxStackSize);
+ // FIXMEDART: move to a shared bindings directory.
+ if (!scriptState || scriptState->isJavaScript())
+ return createScriptCallStackForConsole(maxStackSize);
+
+ return DartUtilities::createScriptCallStack();
}
PassRefPtr<ScriptArguments> createScriptArguments(const v8::FunctionCallbackInfo<v8::Value>& v8arguments, unsigned skipArgumentCount)
« Source/bindings/dart/DartUtilities.cpp ('K') | « Source/bindings/dart/DartUtilities.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698