Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 33973002: Fix for https://code.google.com/p/dart/issues/detail?id=5851 Proper line #s and columns for Dart er… (Closed)

Created:
7 years, 2 months ago by Jacob
Modified:
7 years, 2 months ago
Reviewers:
vsm
CC:
reviews+dom_dartlang.org
Visibility:
Public.

Description

Patch Set 1 : ready to review #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -80 lines) Patch
M LayoutTests/dart/dom/Console-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/dart/inspector/evaluate-in-console-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/dart/microtask-queue-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/dart/DartController.h View 4 chunks +7 lines, -2 lines 0 comments Download
M Source/bindings/dart/DartController.cpp View 3 chunks +39 lines, -21 lines 0 comments Download
M Source/bindings/dart/DartDOMData.h View 3 chunks +12 lines, -0 lines 0 comments Download
M Source/bindings/dart/DartDOMData.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/dart/DartUtilities.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/bindings/dart/DartUtilities.cpp View 3 chunks +95 lines, -44 lines 1 comment Download
M Source/bindings/v8/ScriptCallStackFactory.cpp View 2 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jacob
Companion CL for 33993002 We switch over from using the JS ScriptState to passing a ...
7 years, 2 months ago (2013-10-21 23:53:49 UTC) #1
Jacob
7 years, 2 months ago (2013-10-21 23:53:59 UTC) #2
vsm
lgtm https://chromiumcodereview.appspot.com/33973002/diff/40001/Source/bindings/dart/DartUtilities.cpp File Source/bindings/dart/DartUtilities.cpp (right): https://chromiumcodereview.appspot.com/33973002/diff/40001/Source/bindings/dart/DartUtilities.cpp#newcode38 Source/bindings/dart/DartUtilities.cpp:38: #include "DartScriptState.h" Use the full include path for ...
7 years, 2 months ago (2013-10-22 00:32:02 UTC) #3
Jacob
7 years, 2 months ago (2013-10-22 00:50:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r1461 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698